Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(measure_theory): preliminaries for Haar measure #3195

Closed
wants to merge 12 commits into from
Closed

[Merged by Bors] - feat(measure_theory): preliminaries for Haar measure #3195

wants to merge 12 commits into from

Conversation

fpvandoorn
Copy link
Member

@fpvandoorn fpvandoorn commented Jun 27, 2020 •
edited by urkud

Move properties about lattice operations on encodable types to a new file. These are generalized from lemmas in the measure theory folder, for lattice operations and not just for ennreal. Also move them to the encodable namespace.
Rename outer_measure.Union_aux to encodable.Union_decode2.
Generalize some properties for outer measures to arbitrary complete lattices. This is useful for operations that behave like outer measures on a subset of set α.

Depends on #3189 and #3190 and #3194

@fpvandoorn fpvandoorn added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Jun 27, 2020
@jcommelin jcommelin changed the title feat(measure_theory): preliminaries for Haar measure feat(measure_theory): preliminaries for Haar measure (deps: 3190, 3194) Jun 27, 2020
@bryangingechen bryangingechen changed the title feat(measure_theory): preliminaries for Haar measure (deps: 3190, 3194) feat(measure_theory): preliminaries for Haar measure (deps: 3194) Jun 29, 2020
@fpvandoorn fpvandoorn force-pushed the haar-4 branch 3 times, most recently from 43d89a0 to e829dc1 Compare July 6, 2020 15:54
@fpvandoorn fpvandoorn added awaiting-review The author would like community review of the PR and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Jul 6, 2020
@fpvandoorn fpvandoorn changed the title feat(measure_theory): preliminaries for Haar measure (deps: 3194) feat(measure_theory): preliminaries for Haar measure Jul 6, 2020
jcommelin
jcommelin reviewed Jul 6, 2020
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

sgouezel
sgouezel reviewed Jul 7, 2020
View reviewed changes
Copy link
Collaborator

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I would be happy to have the opinion of @urkud since he's into measure theory currently.

src/data/equiv/encodable/lattice.lean Outdated Show resolved Hide resolved
src/measure_theory/measure_space.lean Outdated Show resolved Hide resolved
src/measure_theory/outer_measure.lean Outdated Show resolved Hide resolved
src/topology/algebra/infinite_sum.lean Outdated Show resolved Hide resolved
src/topology/algebra/infinite_sum.lean Outdated Show resolved Hide resolved
src/topology/algebra/infinite_sum.lean Outdated Show resolved Hide resolved
src/topology/algebra/infinite_sum.lean Outdated Show resolved Hide resolved
@fpvandoorn @sgouezel
Apply suggestions from code review
3b4b3d5 
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
jcommelin
jcommelin reviewed Jul 8, 2020
View reviewed changes
src/topology/algebra/infinite_sum.lean Outdated Show resolved Hide resolved
src/topology/algebra/infinite_sum.lean Show resolved Hide resolved
src/topology/algebra/infinite_sum.lean Outdated Show resolved Hide resolved
src/data/equiv/encodable/lattice.lean Show resolved Hide resolved
src/data/equiv/encodable/lattice.lean Outdated Show resolved Hide resolved
@semorrison semorrison added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jul 8, 2020
@fpvandoorn fpvandoorn added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jul 13, 2020
jcommelin
jcommelin reviewed Jul 13, 2020
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks really good now. However, I'm a bit hesitant to merge this, because of @urkud s ongoing refactor of measure theory and integration stuff.

@fpvandoorn fpvandoorn mentioned this pull request Jul 13, 2020
Closed
@fpvandoorn
Copy link
Member Author

Ok, I'm happy to let @urkud decide which PR to merge first (and to fix merge conflicts if my PR gets deferred).

@urkud
Copy link
Member

urkud commented Jul 14, 2020

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jul 14, 2020
bors bot pushed a commit that referenced this pull request Jul 14, 2020
@fpvandoorn
feat(measure_theory): preliminaries for Haar measure (#3195)
5cb77d8 
Move properties about lattice operations on encodable types to a new file. These are generalized from lemmas in the measure theory folder, for lattice operations and not just for `ennreal`. Also move them to the `encodable` namespace.
Rename `outer_measure.Union_aux` to `encodable.Union_decode2`.
Generalize some properties for outer measures to arbitrary complete lattices. This is useful for operations that behave like outer measures on a subset of `set \a`.
@bors
Copy link

bors bot commented Jul 14, 2020

Build failed:

@jcommelin
Copy link
Member

bors d+

@bors
Copy link

bors bot commented Jul 14, 2020

✌️ fpvandoorn can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@robertylewis robertylewis removed the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Jul 14, 2020
@urkud
Copy link
Member

urkud commented Jul 15, 2020

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Jul 15, 2020
@bryangingechen bryangingechen removed the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Jul 15, 2020
@bryangingechen
Copy link
Collaborator

merge conflict
bors r-

@bryangingechen
Copy link
Collaborator

Odd, I pushed a fix to haar-4 but it doesn't show up here (yet?).

@bryangingechen
Copy link
Collaborator

Let's see if closing and reopening helps?

@urkud
Copy link
Member

urkud commented Jul 15, 2020

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Jul 15, 2020
bors bot pushed a commit that referenced this pull request Jul 15, 2020
@fpvandoorn @robertylewis
@urkud @bryangingechen
feat(measure_theory): preliminaries for Haar measure (#3195)
5fe67b7 
Move properties about lattice operations on encodable types to a new file. These are generalized from lemmas in the measure theory folder, for lattice operations and not just for `ennreal`. Also move them to the `encodable` namespace.
Rename `outer_measure.Union_aux` to `encodable.Union_decode2`.
Generalize some properties for outer measures to arbitrary complete lattices. This is useful for operations that behave like outer measures on a subset of `set α`.



Co-authored-by: Rob Lewis <Rob.y.lewis@gmail.com>
Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
@bors
Copy link

bors bot commented Jul 15, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(measure_theory): preliminaries for Haar measure [Merged by Bors] - feat(measure_theory): preliminaries for Haar measure Jul 15, 2020
@bors bors bot closed this Jul 15, 2020
@bors bors bot deleted the haar-4 branch July 15, 2020 18:22
@fpvandoorn
Copy link
Member Author

Thanks for fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

@sgouezel sgouezel sgouezel left review comments

Assignees

@sgouezel sgouezel

Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@fpvandoorn @urkud @jcommelin @bryangingechen @sgouezel @semorrison @robertylewis