New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(subtype): standardize #3204
Conversation
There are some cases where it got better:
There are some places where it got worse:
I changed |
There were only few linter errors. @kappelmann: I had to remove some simp lemmas in continued fractions, because they went in the other direction (simplifying from coercion to |
add extensionality lemma and ext_iff simplify x.1 to coe x
Trying to rebase on this branch (which will probably need to go through a couple of iterations of fixes): https://github.com/leanprover-community/mathlib/compare/subtype_rebase |
I think there are no more errors here. I would appreciate a quick merge, as this PR is likely to break quickly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
Add simp lemma from x.val to coe x Use correct ext/ext_iff naming scheme Use coe in more places in the library
Pull request successfully merged into master. Build succeeded: |
Add simp lemma from x.val to coe x Use correct ext/ext_iff naming scheme Use coe in more places in the library
Add simp lemma from x.val to coe x
Use correct ext/ext_iff naming scheme
Use coe in more places in the library