[Merged by Bors] - feat(algebra/pointwise): make instances global #3240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urkud
reviewed
Jun 30, 2020
jcommelin
reviewed
Jun 30, 2020
fpvandoorn
force-pushed
the
algebra-pointwise
branch
from
dc12523
to
8a639a8
Compare
|
I'm currently simplifying I'm haven't yet done anything specifically for I think I can finish this tomorrow (depending on the number of errors left). |
fpvandoorn
added
awaiting-review
fpvandoorn
force-pushed
the
algebra-pointwise
branch
from
16fb49e
to
4135264
Compare
|
Please fix merge conflicts. |
|
I will, but feel free to already review the current version. |
much cleanup make many variables implicit make many names shorter add some lemmas add type set_semiring as alias for set, with appropriate instance
fpvandoorn
force-pushed
the
algebra-pointwise
branch
from
531edc5
to
83bc3c3
Compare
jcommelin
approved these changes
Jul 3, 2020
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jul 3, 2020
add image2 and image3, the images of binary and ternary functions cleanup in algebra/pointwise make many variables implicit make many names shorter add some lemmas add more simp lemmas add type set_semiring as alias for set, with semiring instance using union as "addition"
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
cipher1024
pushed a commit
to cipher1024/mathlib
that referenced
this pull request
Mar 15, 2022
…3240) add image2 and image3, the images of binary and ternary functions cleanup in algebra/pointwise make many variables implicit make many names shorter add some lemmas add more simp lemmas add type set_semiring as alias for set, with semiring instance using union as "addition"
bors bot
pushed a commit
that referenced
this pull request
May 16, 2022
Move `set_semiring` to a new file `data.set.semiring`. Crediting Floris for #3240 Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add image2 and image3, the images of binary and ternary functions
cleanup in algebra/pointwise
make many variables implicit
make many names shorter
add some lemmas
add more simp lemmas
add type set_semiring as alias for set, with semiring instance using union as "addition"