[Merged by Bors] - chore(*): work on removing deprecated is_X_hom typeclasses #3258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urkud
reviewed
Jul 1, 2020
urkud
reviewed
Jul 1, 2020
urkud
reviewed
Jul 1, 2020
urkud
reviewed
Jul 1, 2020
|
LGTM modulo a few minor comments. |
|
Note that this PR has conflicts with #3240. |
semorrison
commented
Jul 1, 2020
Yeah :-( |
Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
… into is_ring_hom
semorrison
added
the
awaiting-review
fpvandoorn
approved these changes
Jul 1, 2020
|
bors r+ |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jul 1, 2020
It's far from over, but as I was bumping up against issues in `polynomial.lean` and `mv_polynomial.lean`, I'm going to PR this part for now, and then wait to return to it when other PRs affecting `polynomial.lean` have cleared. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Pull request successfully merged into master. Build succeeded:
|
bors
bot
changed the title
cipher1024
pushed a commit
to cipher1024/mathlib
that referenced
this pull request
Mar 15, 2022
…r-community#3258) It's far from over, but as I was bumping up against issues in `polynomial.lean` and `mv_polynomial.lean`, I'm going to PR this part for now, and then wait to return to it when other PRs affecting `polynomial.lean` have cleared. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's far from over, but as I was bumping up against issues in
polynomial.leanandmv_polynomial.lean, I'm going to PR this part for now, and then wait to return to it when other PRs affectingpolynomial.leanhave cleared.