[Merged by Bors] - refactor(order/filter/at_top): import order.filter.bases #3523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we can use facts about `filter.has_basis` in `filter.at_top`. Also generalize `is_countably_generated_at_top_finset_nat` to `at_top` filter on any `encodable` type.
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jul 23, 2020
This way we can use facts about `filter.has_basis` in `filter.at_top`. Also generalize `is_countably_generated_at_top_finset_nat` to `at_top` filter on any `encodable` type.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we can use facts about
filter.has_basisinfilter.at_top.Also generalize
is_countably_generated_at_top_finset_natto
at_topfilter on anyencodabletype.This is the part of #3478 that actually matches the description of the original PR.