[Merged by Bors] - chore(order/filter/*): use [nonempty _] instead of (_ : nonempty _)
#3526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we can use facts about `filter.has_basis` in `filter.at_top`. Also generalize `is_countably_generated_at_top_finset_nat` to `at_top` filter on any `encodable` type.
In most cases Lean can find an instance automatically.
urkud
added
the
blocked-by-other-PR
gebner
removed
the
blocked-by-other-PR
gebner
changed the title
[nonempty _] instead of (_ : nonempty _) deps: 3523[nonempty _] instead of (_ : nonempty _)
|
Can you merge master, to let us see what is really added by this PR? |
robertylewis
added
the
awaiting-author
urkud
added
awaiting-review
Done. |
|
bors r+ |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jul 23, 2020
…)` (#3526) In most cases Lean can find an instance automatically.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
[nonempty _] instead of (_ : nonempty _)[nonempty _] instead of (_ : nonempty _)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In most cases Lean can find an instance automatically.