Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(order/filter/*): use [nonempty _] instead of (_ : nonempty _) #3526

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - chore(order/filter/*): use [nonempty _] instead of (_ : nonempty _) #3526

wants to merge 5 commits into from

Commits on Jul 23, 2020

  1. refactor(order/filter/at_top): import order.filter.bases 

    This way we can use facts about `filter.has_basis` in `filter.at_top`.

Also generalize `is_countably_generated_at_top_finset_nat`
to `at_top` filter on any `encodable` type.
    @urkud
    urkud committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    4f671c3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'move-at-top' into nonempty-instance

    @urkud
    urkud committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    7ba7b51 View commit details
    Browse the repository at this point in the history

  3. chore(order/filter/*): use [nonempty _] instead of (_ : nonempty _) 

    In most cases Lean can find an instance automatically.
    @urkud
    urkud committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    db70b92 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into move-at-top

    @urkud
    urkud committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    7475939 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'move-at-top' into nonempty-instance

    @urkud
    urkud committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    d09a4e3 View commit details
    Browse the repository at this point in the history