Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(order/rel_iso): a new definition of order_iso, using preorder instances #3838

Closed
wants to merge 16 commits into from

Conversation

awainverse
Copy link
Collaborator

@awainverse awainverse commented Aug 17, 2020

defines (new) order_embedding and order_iso, which map both < and <=
replaces existing rel_embedding and rel_iso instances preserving < or <= with the new abbreviations


Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, it fixes an irritation I've been having for a while.

src/order/rel_iso.lean Show resolved Hide resolved
src/order/rel_iso.lean Outdated Show resolved Hide resolved
src/data/finsupp/lattice.lean Outdated Show resolved Hide resolved
src/linear_algebra/basic.lean Show resolved Hide resolved
@Vierkantor Vierkantor added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Aug 20, 2020
@awainverse awainverse added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Aug 20, 2020
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Anyone with more experience in the order part of the library who wants to comment?

Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been a day so Let's Get This Merged.

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Aug 21, 2020
bors bot pushed a commit that referenced this pull request Aug 21, 2020
…stances (#3838)

defines (new) `order_embedding` and `order_iso`, which map both < and <=
replaces existing `rel_embedding` and `rel_iso` instances preserving < or <= with the new abbreviations
@bors
Copy link

bors bot commented Aug 21, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(order/rel_iso): a new definition of order_iso, using preorder instances [Merged by Bors] - feat(order/rel_iso): a new definition of order_iso, using preorder instances Aug 21, 2020
@bors bors bot closed this Aug 21, 2020
@bors bors bot deleted the rel_order_iso branch August 21, 2020 17:42
jcommelin pushed a commit that referenced this pull request Aug 21, 2020
…stances (#3838)

defines (new) `order_embedding` and `order_iso`, which map both < and <=
replaces existing `rel_embedding` and `rel_iso` instances preserving < or <= with the new abbreviations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants