[Merged by Bors] - chore(order/rel_iso): add a few lemmas #5106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add lemmas `order_iso.apply_eq_iff_eq` etc; * define `order_iso.symm`.
|
This all looks better, thanks |
This was referenced Nov 25, 2020
| @@ -560,40 +579,33 @@ lemma order_iso.map_bot [order_bot α] [order_bot β] | |||
| f ⊥ = ⊥ := | |||
| by { rw [eq_bot_iff, ← f.apply_symm_apply ⊥, ← f.map_rel_iff], apply bot_le, } | |||
|
|
|||
| lemma rel_iso.map_top [order_top α] [order_top β] | |||
| lemma order_iso.map_top [order_top α] [order_top β] | |||
There was a problem hiding this comment.
@awainverse I'm assuming these renamings were missed in #3838?
There was a problem hiding this comment.
Yeah, I think I had trouble making all of these namespace changes work for some reason I've forgotten. Since it all builds, this naming convention's definitely better.
bors bot
pushed a commit
that referenced
this pull request
Nov 27, 2020
* add lemmas `order_iso.apply_eq_iff_eq` etc; * define `order_iso.symm`.
github-actions
bot
added
ready-to-merge
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
order_iso.apply_eq_iff_eqetc;order_iso.symm.