Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

[Merged by Bors] - feat(topology/tactic): optionally make continuity verbose with ? #3962

Closed

Conversation

jesse-michael-han
Copy link
Collaborator


@kim-em
Copy link
Collaborator

kim-em commented Aug 28, 2020

I'm not convinced this gives more useful results than the generic show_term { continuity }.

@jesse-michael-han
Copy link
Collaborator Author

Sure, this is just for convenience. continuity is a thin wrapper around tidy, so why not expose the ? available in the tidy API?

@kim-em
Copy link
Collaborator

kim-em commented Aug 28, 2020

But isn't it just going to print apply_rules continuity, perhaps interleaved with refine continuous.comp _ _?

@jesse-michael-han
Copy link
Collaborator Author

Yes, by definition, it will only print tactics which were available to that particular invocation of tidy. Maybe there will be more continuity tactics in the future; in any case, I think it's convenient to be able to query tidy when I know it's being called.

@kim-em
Copy link
Collaborator

kim-em commented Aug 28, 2020

Could you give an example where the output from continuity? is useful?

I'm hesitant to tack on ? modes for tactics unless they do something better than what show_term can do, and while I absolutely agree that's the case for tidy, I'm not seeing it yet for continuity.

@jesse-michael-han
Copy link
Collaborator Author

OK, it seems like you're saying that ? modes should be as helpful as show_term when possible.

I updated the PR so that continuity? is now equivalent to show_term {continuity}. Hopefully you will agree that being able to write ? is a convenient alternative to typing out show_term { ... }.

If, in the future, there is (say) a continuity tactic which calls simp under the hood and makes show_term not so pleasant, then we can revert to emitting the tidy trace.

@kim-em kim-em added the awaiting-review The author would like community review of the PR label Aug 28, 2020
src/topology/tactic.lean Outdated Show resolved Hide resolved
src/topology/tactic.lean Show resolved Hide resolved
@robertylewis robertylewis added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Aug 28, 2020
@bryangingechen bryangingechen added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Aug 30, 2020
@robertylewis
Copy link
Member

bors merge

bors bot pushed a commit that referenced this pull request Aug 30, 2020
@bors
Copy link

bors bot commented Aug 30, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(topology/tactic): optionally make continuity verbose with ? [Merged by Bors] - feat(topology/tactic): optionally make continuity verbose with ? Aug 30, 2020
@bors bors bot closed this Aug 30, 2020
@YaelDillies YaelDillies removed the awaiting-review The author would like community review of the PR label Nov 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants