Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(topology/path_connected): add lemmas about paths and continuous families of paths #4063

Closed
wants to merge 12 commits into from
Closed

[Merged by Bors] - feat(topology/path_connected): add lemmas about paths and continuous families of paths #4063

wants to merge 12 commits into from

Conversation

ADedecker
Copy link
Member

@ADedecker ADedecker commented Sep 7, 2020 •
edited

From the sphere eversion project (see leanprover-community/sphere-eversion#12)

@ADedecker ADedecker added awaiting-review The author would like community review of the PR blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Sep 7, 2020
@ADedecker ADedecker removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Sep 8, 2020
@semorrison semorrison changed the title feat(topology/path_connected): add lemmas about paths and continuous families of paths (deps: #3694) feat(topology/path_connected): add lemmas about paths and continuous families of paths Sep 10, 2020
sgouezel
sgouezel reviewed Sep 11, 2020
View reviewed changes
src/topology/path_connected.lean Outdated Show resolved Hide resolved
src/topology/path_connected.lean Outdated Show resolved Hide resolved
src/topology/path_connected.lean Outdated Show resolved Hide resolved
src/topology/path_connected.lean Outdated

/-! #### Portion of a path -/

/-- `γ.portion t` is the path which starts by following the path `γ`,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like this definition, because it is somewhat arbitrary that you only keep the beginning of the path. You could have path.truncate_left, path.truncate_right and path.truncate, for instance (or just path.truncate, where you allow truncation on both sides, and where you could use 0 on the left if you want to copy the functionality of your "portion")

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's so arbitrary, because the path is clearly oriented, and I think truncating means keeping the beginning.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest I was also not completely okay with my portion, so I just made your truncate. I'll have to modify my proof in the sphere eversion project but I've made a few tests and it should hopefully not be much longer.

src/topology/path_connected.lean Outdated Show resolved Hide resolved
src/topology/path_connected.lean Outdated Show resolved Hide resolved
@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Sep 11, 2020
@ADedecker ADedecker added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Sep 13, 2020
jcommelin
jcommelin reviewed Sep 18, 2020
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although some proofs are a bit long.
@kckennylau @sgouezel do you have any comments?

src/topology/path_connected.lean Outdated Show resolved Hide resolved
src/topology/path_connected.lean Outdated Show resolved Hide resolved
@kckennylau
Copy link
Collaborator

LGTM

@ADedecker @jcommelin
Apply suggestions from code review
2bf8bb4 
Co-authored-by: Johan Commelin <johan@commelin.net>
@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Sep 18, 2020
@ADedecker ADedecker added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Sep 20, 2020
@sgouezel
Copy link
Collaborator

Thanks!

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Sep 20, 2020
bors bot pushed a commit that referenced this pull request Sep 20, 2020
@PatrickMassot @ADedecker @semorrison
feat(topology/path_connected): add lemmas about paths and continuous …
d774ef6 
…families of paths (#4063)

From the sphere eversion project (see leanprover-community/sphere-eversion#12)



Co-authored-by: Anatole <anatolededecker@gmail.com>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: Anatole Dedecker <48656793+ADedecker@users.noreply.github.com>
@bors
Copy link

bors bot commented Sep 20, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(topology/path_connected): add lemmas about paths and continuous families of paths [Merged by Bors] - feat(topology/path_connected): add lemmas about paths and continuous families of paths Sep 20, 2020
@bors bors bot closed this Sep 20, 2020
@bors bors bot deleted the path-manip branch September 20, 2020 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

@sgouezel sgouezel sgouezel left review comments

@PatrickMassot PatrickMassot Awaiting requested review from PatrickMassot

@kckennylau kckennylau Awaiting requested review from kckennylau

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ADedecker @kckennylau @sgouezel @jcommelin @PatrickMassot @semorrison