Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(topology/path_connected): add lemmas about paths and continuous families of paths #4063
[Merged by Bors] - feat(topology/path_connected): add lemmas about paths and continuous families of paths #4063
Changes from 7 commits
80b38f3
835c493
1024bfc
bad6959
1842bfa
6a4b6fc
10ad7e8
4c7702e
ebab14b
ad46e29
2bf8bb4
a434b20
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like this definition, because it is somewhat arbitrary that you only keep the beginning of the path. You could have
path.truncate_left
,path.truncate_right
andpath.truncate
, for instance (or justpath.truncate
, where you allow truncation on both sides, and where you could use0
on the left if you want to copy the functionality of your "portion")There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's so arbitrary, because the path is clearly oriented, and I think truncating means keeping the beginning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest I was also not completely okay with my
portion
, so I just made yourtruncate
. I'll have to modify my proof in the sphere eversion project but I've made a few tests and it should hopefully not be much longer.