Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - ci(*): run style lint in parallel job, fix update-copy-mod-doc-exceptions.sh #4513

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - ci(*): run style lint in parallel job, fix update-copy-mod-doc-exceptions.sh #4513

wants to merge 2 commits into from

Conversation

bryangingechen
Copy link
Collaborator

Followup to #4486:

  • run the linter in a separate parallel job, per request
  • the update-*.sh script now correctly generates a full exceptions file
  • add some more comments to the shell scripts

@bryangingechen bryangingechen added awaiting-review The author would like community review of the PR CI This issue or PR is about continuous integration labels Oct 7, 2020
@bryangingechen bryangingechen mentioned this pull request Oct 7, 2020
Merged
jcommelin
jcommelin approved these changes Oct 8, 2020
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Oct 8, 2020
bors bot pushed a commit that referenced this pull request Oct 8, 2020
@bryangingechen
ci(*): run style lint in parallel job, fix update-copy-mod-doc-except…
b4dc912 
…ions.sh (#4513)

Followup to #4486:
- run the linter in a separate parallel job, per request
- the update-*.sh script now correctly generates a full exceptions file
- add some more comments to the shell scripts
@bors
Copy link

bors bot commented Oct 8, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title ci(*): run style lint in parallel job, fix update-copy-mod-doc-exceptions.sh [Merged by Bors] - ci(*): run style lint in parallel job, fix update-copy-mod-doc-exceptions.sh Oct 8, 2020
@bors bors bot closed this Oct 8, 2020
@bors bors bot deleted the mod-doc-lint-2 branch October 8, 2020 05:31
gebner
gebner reviewed Oct 8, 2020
View reviewed changes
scripts/update-copy-mod-doc-exceptions.sh

# use C locale so that sorting is the same on macOS and Linux
# see https://unix.stackexchange.com/questions/362728/why-does-gnu-sort-sort-differently-on-my-osx-machine-and-linux-machine
LC_ALL=C find src archive -name '*.lean' | xargs ./scripts/lint-copy-mod-doc.py | sort > scripts/copy-mod-doc-exceptions.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not have the effect you think it does. LC_ALL only applies to the find. You need to write LC_ALL=C sort instead.

scripts/update-copy-mod-doc-exceptions.sh
Comment on lines +7 to +8
# Replace the current exceptions file with an empty file
> scripts/copy-mod-doc-exceptions.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already implicitly happening on the line below, with the > scripts/copy-mod-doc-exceptions.txt.

gebner
gebner reviewed Oct 8, 2020
View reviewed changes
Copy link
Member

@gebner gebner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github makes it really hard to add review comments after a PR has been merged. You can't use suggestions!

Additionally you are required to provide a comment such as this one.

@bryangingechen
Copy link
Collaborator Author

@gebner Thanks! Turns out I don't understand how pipes and redirection actually work... PR incoming.

@bryangingechen bryangingechen mentioned this pull request Oct 8, 2020
Closed
bors bot pushed a commit that referenced this pull request Oct 8, 2020
@bryangingechen
fix(update-copy-mod-doc-exceptions.sh): cleanup, sort properly (#4533)
b67bb8d 
Followup to #4513.
bors bot pushed a commit that referenced this pull request Oct 8, 2020
@bryangingechen
fix(update-copy-mod-doc-exceptions.sh): cleanup, sort properly (#4533)
0ae4a3d 
Followup to #4513.
bors bot pushed a commit that referenced this pull request Jun 1, 2023
@adomani
chore(field_theory/ratfunc): use section instead of omit/include (#…
f9b523e 
…19133)

This hopefully closes [#4513](leanprover-community/mathlib4#4513) (or at least mitigates it) and will settle [!4#4373](leanprover-community/mathlib4#4373) in mathlib3.
bors bot pushed a commit that referenced this pull request Jun 1, 2023
@adomani @Vierkantor
chore(field_theory/ratfunc): use section instead of omit/include (#…
6723746 
…19133)

This hopefully closes [#4513](leanprover-community/mathlib4#4513) (or at least mitigates it) and will settle [!4#4373](leanprover-community/mathlib4#4373) in mathlib3.




Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gebner gebner gebner left review comments

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
CI This issue or PR is about continuous integration ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bryangingechen @gebner @jcommelin