chore: Small variable cleanup in FieldTheory/RatFunc
#4373
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adomani
added
the
awaiting-review
|
I think the hacks here might be symptomatic of a bigger issue that happened when porting this file, so I'm wary of merging this as is. |
|
Eric, would a better solution be to add various sections, to isolate the |
|
Yes, that certainly sounds better; though that might be a post-port job. |
adomani
added
after-port
and removed
awaiting-review
|
Ok, I'll leave this be, and mark it as |
Ruben-VandeVelde
changed the title
variable cleanupvariable cleanup in FieldTheory/RatFunc
This was referenced May 31, 2023
bors bot
pushed a commit
to leanprover-community/mathlib
that referenced
this pull request
Jun 1, 2023
…19133) This hopefully closes [#4513](leanprover-community/mathlib4#4513) (or at least mitigates it) and will settle [!4#4373](leanprover-community/mathlib4#4373) in mathlib3.
bors bot
pushed a commit
to leanprover-community/mathlib
that referenced
this pull request
Jun 1, 2023
…19133) This hopefully closes [#4513](leanprover-community/mathlib4#4513) (or at least mitigates it) and will settle [!4#4373](leanprover-community/mathlib4#4373) in mathlib3. Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
qawbecrdtey
pushed a commit
to qawbecrdtey/greedoid-mathlib4
that referenced
this pull request
Jun 12, 2023
…#4580) This PR re-ports `FieldTheory/RatFunc`, now that the mathlib3 version uses `section`s, after PR[#19133](leanprover-community/mathlib#19133). This closes [leanprover-community#4513](leanprover-community#4513) and closes leanprover-community#4373. Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes some unnecessary introduction of new
variables, favouring recycling of pre-existing one. This exploits the new feature of getting Lean to figure out what variables toinclude/omitautomatically.