Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/set/intervals/pi): lemmas about intervals in Π i, π i #4951

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat(data/set/intervals/pi): lemmas about intervals in Π i, π i #4951

wants to merge 5 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Nov 8, 2020

Also add missing lemmas Ixx_mem_nhds and lemmas pi_Ixx_mem_nhds.
For each pi_Ixx_mem_nhds I add a non-dependent version
pi_Ixx_mem_nhds' because sometimes Lean fails to unify different
instances while trying to apply the dependent version to ι → ℝ.

@urkud
feat(data/set/intervals/pi): lemmas about intervals in Π i, π i
d46a84b 
Also add missing lemmas `Ixx_mem_nhds` and lemmas `pi_Ixx_mem_nhds`.
For each `pi_Ixx_mem_nhds` I add a non-dependent version
`pi_Ixx_mem_nhds'` because sometimes Lean fails to unify different
instances while trying to apply the dependent version to `ι → ℝ`.
@urkud urkud added the awaiting-review The author would like community review of the PR label Nov 8, 2020
@PatrickMassot
Copy link
Member

For each pi_Ixx_mem_nhds I add a non-dependent version
pi_Ixx_mem_nhds' because sometimes Lean fails to unify different
instances while trying to apply the dependent version to ι → ℝ.

Could you please put that explanation somewhere in the file?

bors d+

@bors
Copy link

bors bot commented Nov 8, 2020

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@PatrickMassot PatrickMassot added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Nov 8, 2020
@urkud urkud removed the awaiting-author A reviewer has asked the author a question or requested changes label Nov 8, 2020
@urkud
Copy link
Member Author

urkud commented Nov 8, 2020

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Nov 8, 2020
bors bot pushed a commit that referenced this pull request Nov 8, 2020
@urkud
feat(data/set/intervals/pi): lemmas about intervals in Π i, π i (#4951
3c875e8 
)

Also add missing lemmas `Ixx_mem_nhds` and lemmas `pi_Ixx_mem_nhds`.
For each `pi_Ixx_mem_nhds` I add a non-dependent version
`pi_Ixx_mem_nhds'` because sometimes Lean fails to unify different
instances while trying to apply the dependent version to `ι → ℝ`.
@urkud
Copy link
Member Author

urkud commented Nov 9, 2020

bors merge

bors bot pushed a commit that referenced this pull request Nov 9, 2020
@urkud
feat(data/set/intervals/pi): lemmas about intervals in Π i, π i (#4951
40f673e 
)

Also add missing lemmas `Ixx_mem_nhds` and lemmas `pi_Ixx_mem_nhds`.
For each `pi_Ixx_mem_nhds` I add a non-dependent version
`pi_Ixx_mem_nhds'` because sometimes Lean fails to unify different
instances while trying to apply the dependent version to `ι → ℝ`.
@bors
Copy link

bors bot commented Nov 9, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/set/intervals/pi): lemmas about intervals in Π i, π i [Merged by Bors] - feat(data/set/intervals/pi): lemmas about intervals in Π i, π i Nov 9, 2020
@bors bors bot closed this Nov 9, 2020
@bors bors bot deleted the pi-Ixx branch November 9, 2020 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@urkud @PatrickMassot