Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(ring_theory/perfection): perfection and tilt #5032

Closed
wants to merge 11 commits into from
Closed

[Merged by Bors] - feat(ring_theory/perfection): perfection and tilt #5032

wants to merge 11 commits into from

Conversation

kckennylau
Copy link
Collaborator

@kckennylau kckennylau commented Nov 18, 2020 •
edited by github-actions bot

@alexjbest
Copy link
Member

minor comment: Isn't this normally called "perfection" rather than "perfectization"?

@jcommelin jcommelin changed the title feat(ring_theory/perfectization) perfectization and tilt feat(ring_theory/perfection) perfection and tilt Nov 18, 2020
@jcommelin jcommelin changed the title feat(ring_theory/perfection) perfection and tilt feat(ring_theory/perfection): perfection and tilt Nov 18, 2020
@bryangingechen bryangingechen added the awaiting-review The author would like community review of the PR label Nov 18, 2020
@kckennylau @eric-wieser
Apply suggestions from code review
e04a2f3 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
jcommelin
jcommelin reviewed Nov 19, 2020
View reviewed changes
src/ring_theory/perfection.lean Outdated Show resolved Hide resolved
src/ring_theory/perfection.lean Outdated Show resolved Hide resolved
src/ring_theory/perfection.lean Outdated Show resolved Hide resolved
src/ring_theory/perfection.lean Outdated Show resolved Hide resolved
src/ring_theory/perfection.lean Outdated Show resolved Hide resolved
src/ring_theory/perfection.lean Outdated Show resolved Hide resolved
@jcommelin
Copy link
Member

Would you mind splitting of the char_p stuff into a separate PR? I'll try my best to do a review of the tilt/perfection stuff this week.

@kckennylau
Copy link
Collaborator Author

Can we do everything here?

jcommelin
jcommelin reviewed Nov 25, 2020
View reviewed changes
src/ring_theory/perfection.lean Outdated Show resolved Hide resolved
src/ring_theory/perfection.lean Outdated Show resolved Hide resolved
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Nov 27, 2020
@kckennylau @jcommelin
Update src/ring_theory/perfection.lean
5658f18 
Co-authored-by: Johan Commelin <johan@commelin.net>
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Nov 28, 2020
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Dec 1, 2020
jcommelin
jcommelin reviewed Dec 1, 2020
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good to me. But I would like some help on 1 point.

src/ring_theory/perfection.lean Outdated

-/

universes u v w
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Later on, you'll use v for a valuation. I think it helps avoid confusion if we don't use it for a universe variable as well.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

src/ring_theory/perfection.lean Show resolved Hide resolved
@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-author A reviewer has asked the author a question or requested changes labels Dec 1, 2020
bors bot pushed a commit that referenced this pull request Dec 1, 2020
@kckennylau
feat(ring_theory/perfection): perfection and tilt (#5032)
9e78823 
- [x] depends on: #5132
@bors
Copy link

bors bot commented Dec 1, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(ring_theory/perfection): perfection and tilt [Merged by Bors] - feat(ring_theory/perfection): perfection and tilt Dec 1, 2020
@bors bors bot closed this Dec 1, 2020
@bors bors bot deleted the perfectization branch December 1, 2020 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@jcommelin jcommelin jcommelin left review comments

@fpvandoorn fpvandoorn fpvandoorn left review comments

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kckennylau @alexjbest @jcommelin @eric-wieser @fpvandoorn @bryangingechen