Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(algebra/char_p): refactor char_p #5132

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - chore(algebra/char_p): refactor char_p #5132

wants to merge 4 commits into from

Conversation

kckennylau
Copy link
Collaborator

@kckennylau kckennylau mentioned this pull request Nov 27, 2020
Closed
1 task
jcommelin
jcommelin reviewed Nov 27, 2020
View reviewed changes
src/algebra/char_p/basic.lean Outdated
instance char_p (R : Type u) [semiring R] : char_p R (ring_char R) :=
⟨spec R⟩

theorem of_eq {R : Type u} [semiring R] {p : ℕ} (h : ring_char R = p) : char_p R p :=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to generalise ring_char R to q (given the instance above this statement)?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand. What is the alternative statement?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it should be called char_p.congr:

theorem congr {R : Type u} [semiring R] {p : ℕ} (q : ℕ) [char_p R q] (h : q = p) : char_p R p :=

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But then why can't I just rewrite?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't you rewrite instead of the current statement?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@bryangingechen bryangingechen added the awaiting-review The author would like community review of the PR label Nov 27, 2020
jcommelin
jcommelin approved these changes Nov 28, 2020
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Nov 28, 2020
bors bot pushed a commit that referenced this pull request Nov 28, 2020
@kckennylau
chore(algebra/char_p): refactor char_p (#5132)
b1d8b89
@bors
Copy link

bors bot commented Nov 28, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(algebra/char_p): refactor char_p [Merged by Bors] - chore(algebra/char_p): refactor char_p Nov 28, 2020
@bors bors bot closed this Nov 28, 2020
@bors bors bot deleted the char-p branch November 28, 2020 19:27
bors bot pushed a commit that referenced this pull request Dec 1, 2020
@kckennylau
feat(ring_theory/perfection): perfection and tilt (#5032)
9e78823 
- [x] depends on: #5132
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kckennylau @jcommelin @bryangingechen