Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(computability/*FA): Deterministic and Nondeterministic Finite Automata #5038

Closed
wants to merge 53 commits into from

Conversation

foxthomson
Copy link
Collaborator

@foxthomson foxthomson commented Nov 18, 2020

Definition and equivalence of NFA's and DFA's


@foxthomson foxthomson closed this Nov 18, 2020
@foxthomson foxthomson changed the title feat(computability/*FA) - Detemdeterministic feat(computability/*FA) - Deterministic and Nondeterministic Finite Automata Nov 18, 2020
@foxthomson foxthomson reopened this Nov 18, 2020
@foxthomson foxthomson added the awaiting-review The author would like community review of the PR label Nov 18, 2020
@jcommelin jcommelin changed the title feat(computability/*FA) - Deterministic and Nondeterministic Finite Automata feat(computability/*FA): Deterministic and Nondeterministic Finite Automata Nov 19, 2020
src/computability/NFA.lean Outdated Show resolved Hide resolved
src/computability/NFA.lean Outdated Show resolved Hide resolved
foxthomson and others added 3 commits November 25, 2020 15:45
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Copy link
Collaborator

@bryangingechen bryangingechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor formatting suggestions.

src/computability/DFA.lean Outdated Show resolved Hide resolved
src/computability/DFA.lean Outdated Show resolved Hide resolved
src/computability/DFA.lean Outdated Show resolved Hide resolved
src/computability/DFA.lean Outdated Show resolved Hide resolved
src/computability/DFA.lean Outdated Show resolved Hide resolved
src/computability/NFA.lean Outdated Show resolved Hide resolved
src/computability/NFA.lean Outdated Show resolved Hide resolved
src/computability/NFA.lean Outdated Show resolved Hide resolved
src/computability/NFA.lean Outdated Show resolved Hide resolved
src/computability/NFA.lean Outdated Show resolved Hide resolved
foxthomson and others added 9 commits November 25, 2020 20:31
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
@foxthomson foxthomson added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Dec 9, 2020
@github-actions github-actions bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Dec 9, 2020
@bryangingechen
Copy link
Collaborator

@foxthomson We recently added a GitHub Action that handles the "blocked-by-other-PR" label. It checks the PR comment for lines that start with - [ ] depends on: #PR_number and then adds / removes the tag depending on the statuses of those PRs. I've gone ahead and added the appropriate lines to your PR comments so that the dependent PRs will be tracked by this automation.

@github-actions github-actions bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Dec 12, 2020
bors bot pushed a commit that referenced this pull request Dec 14, 2020
Lifted from #5036 in order to include in #5038 as well.



Co-authored-by: foxthomson <11833933+foxthomson@users.noreply.github.com>
@github-actions github-actions bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Dec 14, 2020
@github-actions
Copy link

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

@foxthomson foxthomson added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Dec 31, 2020
Copy link
Member

@gebner gebner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

src/computability/NFA.lean Outdated Show resolved Hide resolved
src/computability/NFA.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Jan 2, 2021

✌️ foxthomson can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@bryangingechen bryangingechen added awaiting-author A reviewer has asked the author a question or requested changes delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jan 2, 2021
@foxthomson
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Jan 3, 2021
…tomata (#5038)

Definition and equivalence of NFA's and DFA's



Co-authored-by: foxthomson <11833933+foxthomson@users.noreply.github.com>
@bors
Copy link

bors bot commented Jan 3, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(computability/*FA): Deterministic and Nondeterministic Finite Automata [Merged by Bors] - feat(computability/*FA): Deterministic and Nondeterministic Finite Automata Jan 3, 2021
@bors bors bot closed this Jan 3, 2021
@bors bors bot deleted the automata branch January 3, 2021 18:13
pglutz pushed a commit that referenced this pull request Jan 6, 2021
…tomata (#5038)

Definition and equivalence of NFA's and DFA's



Co-authored-by: foxthomson <11833933+foxthomson@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-author A reviewer has asked the author a question or requested changes delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants