Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(group_theory/perm/basic): Bundle sigma_congr_right and sum_congr into monoid_homs #5301

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat(group_theory/perm/basic): Bundle sigma_congr_right and sum_congr into monoid_homs #5301

wants to merge 4 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Dec 10, 2020 •
edited

This makes the corresponding subgroups available as monoid_hom.range.

As a result, the old subgroup definitions can be removed.

This also adds injectivity and cardinality lemmas.

This PR is an alternative to a replacement for #5279

@eric-wieser eric-wieser mentioned this pull request Dec 10, 2020
Closed
1 task
@eric-wieser eric-wieser changed the title feat(gruop_theory/perm/basic): Bundle sigma_congr_right and sum_congr into monoid_homs feat(group_theory/perm/basic): Bundle sigma_congr_right and sum_congr into monoid_homs Dec 10, 2020
@eric-wieser eric-wieser added the awaiting-review The author would like community review of the PR label Dec 10, 2020
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Dec 10, 2020
@Vierkantor
Copy link
Collaborator

Shall we close this PR since the alternative got merged?

@eric-wieser eric-wieser added WIP Work in progress and removed awaiting-review The author would like community review of the PR labels Dec 14, 2020
@eric-wieser
Copy link
Member Author

eric-wieser commented Dec 14, 2020 •
edited

I think I've found that actually this version was the better choice, as it made expressing fintype.card (sum_congr_hom.range) much easier that that alternative PR made it. I'll revive it once I get #5269 working, which was the motivation for this.

@eric-wieser
Copy link
Member Author

I've gotten #5269 working, and concluded I do want this - but it will be tidier with #5368 and #5371 in first.

@eric-wieser eric-wieser added blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. and removed WIP Work in progress labels Dec 14, 2020
@github-actions github-actions bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Dec 15, 2020
@github-actions
Copy link

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Dec 15, 2020
@eric-wieser eric-wieser added the awaiting-review The author would like community review of the PR label Dec 15, 2020
Vierkantor
Vierkantor approved these changes Dec 15, 2020
View reviewed changes
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Dec 15, 2020
@bors
Copy link

bors bot commented Dec 15, 2020

Canceled.

eric-wieser
eric-wieser commented Dec 15, 2020
View reviewed changes
src/group_theory/perm/subgroup.lean

instance sigma_congr_right_subgroup.decidable_mem {α : Type*} {β : α → Type*}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lemma isn't needed any more now that we have monoid_hom.decidable_mem_range

@eric-wieser
Copy link
Member Author

Looks like our streams crossed there - I just pushed a golf that I missed.

@Vierkantor
Copy link
Collaborator

I saw "eric-wieser added the awaiting-review label 6 minutes ago" and thought you were ready. Let me know when you're done, and we can get it merged.

@eric-wieser
Copy link
Member Author

I'm done - I realized after double checking that I had forgotten to push one of my files.

@eric-wieser eric-wieser mentioned this pull request Dec 15, 2020
Closed
16 tasks
Vierkantor
Vierkantor approved these changes Dec 15, 2020
View reviewed changes
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot pushed a commit that referenced this pull request Dec 15, 2020
@eric-wieser
feat(group_theory/perm/basic): Bundle sigma_congr_right and sum_congr…
dd72a98 
… into monoid_homs (#5301)

This makes the corresponding subgroups available as `monoid_hom.range`.

As a result, the old subgroup definitions can be removed.

This also adds injectivity and cardinality lemmas.
@bors
Copy link

bors bot commented Dec 15, 2020

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(group_theory/perm/basic): Bundle sigma_congr_right and sum_congr into monoid_homs [Merged by Bors] - feat(group_theory/perm/basic): Bundle sigma_congr_right and sum_congr into monoid_homs Dec 15, 2020
@bors bors bot closed this Dec 15, 2020
@bors bors bot deleted the eric-wieser/perm-homs branch December 15, 2020 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vierkantor Vierkantor Vierkantor approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eric-wieser @Vierkantor