Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(measure_theory/lebesgue_measure): volume of a box in ℝⁿ #5635

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - feat(measure_theory/lebesgue_measure): volume of a box in ℝⁿ #5635

wants to merge 9 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jan 6, 2021 •
edited by github-actions bot

@urkud urkud added the awaiting-review The author would like community review of the PR label Jan 6, 2021
@github-actions github-actions bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Jan 6, 2021
fpvandoorn
fpvandoorn reviewed Jan 11, 2021
View reviewed changes
Copy link
Member

@fpvandoorn fpvandoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Can you add a section header when the file moves from ℝ to ι → ℝ?

src/measure_theory/lebesgue_measure.lean Outdated Show resolved Hide resolved
src/measure_theory/lebesgue_measure.lean Show resolved Hide resolved
@github-actions github-actions bot added merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Jan 12, 2021
@github-actions
Copy link

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Jan 12, 2021
@bors
Copy link

bors bot commented Jan 12, 2021

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 13, 2021
@urkud urkud removed the awaiting-author A reviewer has asked the author a question or requested changes label Jan 13, 2021
@urkud
Copy link
Member Author

urkud commented Jan 14, 2021

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Jan 14, 2021
bors bot pushed a commit that referenced this pull request Jan 14, 2021
@urkud
feat(measure_theory/lebesgue_measure): volume of a box in ℝⁿ (#5635)
d11d83a
@bors
Copy link

bors bot commented Jan 14, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(measure_theory/lebesgue_measure): volume of a box in ℝⁿ [Merged by Bors] - feat(measure_theory/lebesgue_measure): volume of a box in ℝⁿ Jan 14, 2021
@bors bors bot closed this Jan 14, 2021
@bors bors bot deleted the pi-lebesgue branch January 14, 2021 05:24
b-mehta pushed a commit that referenced this pull request Jan 16, 2021
@urkud @b-mehta
feat(measure_theory/lebesgue_measure): volume of a box in ℝⁿ (#5635)
3e2ed60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpvandoorn fpvandoorn fpvandoorn left review comments

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @fpvandoorn @sgouezel