Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(measure_theory/interval_integral): FTC-2 for the open set #5733

Closed
wants to merge 3 commits into from

Conversation

benjamindavidson
Copy link
Collaborator

A follow-up to #4945. I replaced integral_eq_sub_of_has_deriv_at' with a stronger version that holds for functions that have a derivative on an Ioo (as opposed to an Ico). Inspired by this conversation on Zulip.

I also emended docstrings to reflect changes made in #5647.

@benjamindavidson benjamindavidson added the awaiting-review The author would like community review of the PR label Jan 14, 2021
Copy link
Member

@hrmacbeth hrmacbeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favour of this change. I left a few stylistic comments.

src/measure_theory/interval_integral.lean Outdated Show resolved Hide resolved
src/measure_theory/interval_integral.lean Outdated Show resolved Hide resolved
src/measure_theory/interval_integral.lean Outdated Show resolved Hide resolved
src/measure_theory/interval_integral.lean Outdated Show resolved Hide resolved
@hrmacbeth hrmacbeth added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 14, 2021
@benjamindavidson benjamindavidson added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 14, 2021
src/measure_theory/interval_integral.lean Show resolved Hide resolved
src/measure_theory/interval_integral.lean Outdated Show resolved Hide resolved
src/measure_theory/interval_integral.lean Outdated Show resolved Hide resolved
@hrmacbeth hrmacbeth added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 14, 2021
@benjamindavidson benjamindavidson added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 15, 2021
Copy link
Member

@hrmacbeth hrmacbeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's pass on to the measure theory people.

@robertylewis
Copy link
Member

This looks like a good change to me! Is the question for @urkud / @sgouezel whether the change is wanted or whether the proof can be shortened?

@benjamindavidson
Copy link
Collaborator Author

benjamindavidson commented Jan 20, 2021

@robertylewis I think we were just waiting for their approval, I don't think there was a specific question.

@hrmacbeth
Copy link
Member

@robertylewis I haven't worked on the measure theory library, so didn't want to merge it on my own authority ... maybe it's ok if it looks good to you too.

@robertylewis
Copy link
Member

It looks unlikely to be controversial and very easy to fix if it is, and I get the sense the measure theory people are busy these days, so let's just merge!

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jan 21, 2021
bors bot pushed a commit that referenced this pull request Jan 21, 2021
A follow-up to #4945. I replaced `integral_eq_sub_of_has_deriv_at'` with a stronger version that holds for functions that have a derivative on an `Ioo` (as opposed to an `Ico`). Inspired by [this](https://leanprover.zulipchat.com/#narrow/stream/116395-maths/topic/FTC-2.20on.20open.20set/near/222177308) conversation on Zulip.

I also emended docstrings to reflect changes made in #5647.
@bors
Copy link

bors bot commented Jan 21, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(measure_theory/interval_integral): FTC-2 for the open set [Merged by Bors] - feat(measure_theory/interval_integral): FTC-2 for the open set Jan 21, 2021
@bors bors bot closed this Jan 21, 2021
@bors bors bot deleted the ftc2_open branch January 21, 2021 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants