Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(measure_theory/interval_integral): FTC-2 #4945

Closed
wants to merge 24 commits into from

Conversation

benjamindavidson
Copy link
Collaborator

@benjamindavidson benjamindavidson commented Nov 8, 2020

The second fundamental theorem of calculus and supporting lemmas

@benjamindavidson benjamindavidson added the WIP Work in progress label Nov 8, 2020
@benjamindavidson benjamindavidson changed the title feat(measure_theory/interval_integral): ftc-2 feat(measure_theory/interval_integral): FTC-2 Nov 8, 2020
@urkud
Copy link
Member

urkud commented Nov 22, 2020

@benjamindavidson I've merged master and fixed some statements. I didn't touch the proofs.

@benjamindavidson benjamindavidson added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Dec 19, 2020
Copy link
Collaborator

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The measurability assumptions on f' when you assume that it is continuous on the relevant interval feel really strange. Of course, I understand that it comes from the current implementation in terms of the restricted measure, but it hints that a refactor might be a good idea. Still, this should wait in any case for another PR.

src/measure_theory/interval_integral.lean Outdated Show resolved Hide resolved
continuous_on (λ u, ∫ x in a..u, f x) s :=
(integral_of_continuous_differentiable_on hintg hcont).continuous_on

theorem integral_eq_sub_of_has_deriv_right_of_le (hab : a ≤ b) (hcont : continuous_on f (Icc a b))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why of_le in the name?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this form assumes a ≤ b. Should we move le somewhere else?

src/measure_theory/interval_integral.lean Outdated Show resolved Hide resolved
@hrmacbeth
Copy link
Member

hrmacbeth commented Dec 20, 2020

The measurability assumptions on f' when you assume that it is continuous on the relevant interval feel really strange. Of course, I understand that it comes from the current implementation in terms of the restricted measure, but it hints that a refactor might be a good idea.

Yes, I was surprised by this too recently (had to do something similar in #5288).

(EDIT: I see it's for a variant of the lemmas from #5288, so not surprising.)

@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Dec 20, 2020
@benjamindavidson
Copy link
Collaborator Author

@sgouezel Yury will have to answer the other questions/concerns you raised, I'm not sure about them myself.

@urkud
Copy link
Member

urkud commented Dec 22, 2020

The measurability assumptions on f' when you assume that it is continuous on the relevant interval feel really strange. Of course, I understand that it comes from the current implementation in terms of the restricted measure, but it hints that a refactor might be a good idea. Still, this should wait in any case for another PR.

This is a side-effect of my choice to use measure.restrict instead of indicator and someone else's choice to use measurable f instead of ∀ s, measurable s → is_null_measurable (f ⁻¹' s). There are a few possible refactors of different scale that would allow us to drop this assumption:

  1. Introduce null_measurable_fun and replace most of measurable f with null_measurable_fun f.
  2. Use the definition of Bochner integral from Wikipedia. In particular, this definition does not assume that the whole space is separable, and uses weaker measurability assumptions than our definition.
  3. Go back to the approach "integral over a set is defined as the integral of the indicator" instead of "integral w.r.t. the restriction of the measure".

bors bot pushed a commit that referenced this pull request Dec 22, 2020
…oi x] x` (#5472)

In many parts of the library we prefer `𝓝[Ici x] x` to `𝓝[Ioi x]
x` (e.g., in assumptions line `continuous_within_at`). Fix MVT and
Gronwall's inequality to use it if possible.

Motivated by #4945
@sgouezel
Copy link
Collaborator

Does it seem reasonable to try to replace the measurable f assumption in integrable f with the existence of a measurable g which coincides almost everywhere with f? I may give it a try if you think it might be a good move. (This is a version of null_measurable_fun f, but for which the refactor doesn't seem to be too big).

@urkud urkud added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Dec 30, 2020
@sgouezel
Copy link
Collaborator

sgouezel commented Jan 3, 2021

Let's merge this. I'll adjust #5510 accordingly afterwards.
bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jan 3, 2021
bors bot pushed a commit that referenced this pull request Jan 3, 2021
The second fundamental theorem of calculus and supporting lemmas


Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
@bors
Copy link

bors bot commented Jan 4, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(measure_theory/interval_integral): FTC-2 [Merged by Bors] - feat(measure_theory/interval_integral): FTC-2 Jan 4, 2021
@bors bors bot closed this Jan 4, 2021
@bors bors bot deleted the ftc2 branch January 4, 2021 02:31
pglutz pushed a commit that referenced this pull request Jan 6, 2021
The second fundamental theorem of calculus and supporting lemmas


Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
bors bot pushed a commit that referenced this pull request Jan 21, 2021
A follow-up to #4945. I replaced `integral_eq_sub_of_has_deriv_at'` with a stronger version that holds for functions that have a derivative on an `Ioo` (as opposed to an `Ico`). Inspired by [this](https://leanprover.zulipchat.com/#narrow/stream/116395-maths/topic/FTC-2.20on.20open.20set/near/222177308) conversation on Zulip.

I also emended docstrings to reflect changes made in #5647.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants