[Merged by Bors] - chore(linear_algebra/std_basis): move std_basis to a new file #6020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
added
the
awaiting-review
linear_algebra/basic is _very_ long. This reduces its length by about 5%. Authorship of the std_basis stuff seems to come almost entirely from 10a586b. None of the lemmas have changed, and the variables are kept in exactly the same order as before.
eric-wieser
force-pushed
the
eric-wieser/split-linear_algebra.basic
branch
from
4ffd786
to
052d523
Compare
Vierkantor
approved these changes
Feb 4, 2021
| elsewhere. | ||
|
|
||
| To give a concrete example, `std_basis R (λ (i : fin 3), R) i 1` gives the `i`th unit basis vector | ||
| in `R³`, and `pi.is_basis_fun` proves this is a basis over `fin 3 → R`. |
There was a problem hiding this comment.
Since this file doesn't actually prove that the standard basis is a basis, maybe the import hierarchy should go basic.lean -> basis.lean -> std_basis.lean?
|
Moving the is_basis statements is probably a good idea, but since I don't plan to come back to this today my preference would be just to merge it so that the build time is slightly shorter (not incurring |
|
Sounds good. Maybe I'll look into moving the bors r+ |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Feb 4, 2021
linear_algebra/basic is _very_ long. This reduces its length by about 5%. Authorship of the std_basis stuff seems to come almost entirely from 10a586b. None of the lemmas have changed, and the variables are kept in exactly the same order as before.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Vierkantor
added a commit
that referenced
this pull request
Feb 5, 2021
This is a follow-up to #6020 which moved `std_basis` to a new file, now we move results about `std_basis` to that same file.
bors bot
pushed a commit
that referenced
this pull request
Feb 5, 2021
…6054) This is a follow-up to #6020 which moved `std_basis` to a new file: now move results from `basis.lean` to that same file. CC @eric-wieser Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
b-mehta
pushed a commit
that referenced
this pull request
Apr 2, 2021
linear_algebra/basic is _very_ long. This reduces its length by about 5%. Authorship of the std_basis stuff seems to come almost entirely from 10a586b. None of the lemmas have changed, and the variables are kept in exactly the same order as before.
b-mehta
pushed a commit
that referenced
this pull request
Apr 2, 2021
…6054) This is a follow-up to #6020 which moved `std_basis` to a new file: now move results from `basis.lean` to that same file. CC @eric-wieser Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linear_algebra/basic is very long. This reduces its length by about 5%.
Authorship of the std_basis stuff seems to come almost entirely from 10a586b.
None of the lemmas have changed, and the variables are kept in exactly the same order as before.