[Merged by Bors] - chore(linear_algebra): move is_basis_std_basis to std_basis.lean
#6054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up to #6020 which moved `std_basis` to a new file, now we move results about `std_basis` to that same file.
Vierkantor
added
the
awaiting-review
eric-wieser
reviewed
Feb 5, 2021
src/linear_algebra/std_basis.lean
Outdated
|
|
||
| ## Main definitions | ||
|
|
||
| - `std_basis R ϕ i b`: the `i`'th standard `R`-basis vector on `Π i, ϕ i` |
There was a problem hiding this comment.
It's not exactly scaled since φ is just a semimodule. I'll use that for now unless someone has a nice alternative.
There was a problem hiding this comment.
Oh, I see your point - the semimodule may not have a 1.
eric-wieser
approved these changes
Feb 5, 2021
eric-wieser
reviewed
Feb 5, 2021
Vierkantor
commented
Feb 5, 2021
eric-wieser
reviewed
Feb 5, 2021
eric-wieser
reviewed
Feb 5, 2021
eric-wieser
reviewed
Feb 5, 2021
Vierkantor
commented
Feb 5, 2021
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
bors d+ |
|
✌️ Vierkantor can now approve this pull request. To approve and merge a pull request, simply reply with |
eric-wieser
reviewed
Feb 5, 2021
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
I'll let @eric-wieser look for one more style suggestion, then I will merge :) |
eric-wieser
approved these changes
Feb 5, 2021
|
bors r+ |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Feb 5, 2021
…6054) This is a follow-up to #6020 which moved `std_basis` to a new file: now move results from `basis.lean` to that same file. CC @eric-wieser Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
is_basis_std_basis to std_basis.leanis_basis_std_basis to std_basis.lean
b-mehta
pushed a commit
that referenced
this pull request
Apr 2, 2021
…6054) This is a follow-up to #6020 which moved `std_basis` to a new file: now move results from `basis.lean` to that same file. CC @eric-wieser Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #6020 which moved
std_basisto a new file: now move results frombasis.leanto that same file.CC @eric-wieser