Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(geometry/manifold): add charted_space and model_with_corners for pi types #6578

Closed
wants to merge 21 commits into from
Closed

[Merged by Bors] - feat(geometry/manifold): add charted_space and model_with_corners for pi types #6578

wants to merge 21 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Mar 7, 2021 •
edited

@github-actions github-actions bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Mar 7, 2021
@urkud urkud added the WIP Work in progress label Mar 8, 2021
@github-actions github-actions bot added merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Mar 10, 2021
@github-actions github-actions bot added merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed merge-conflict Please `git merge origin/master` then a bot will remove this label. labels Mar 28, 2021
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Apr 3, 2021
@github-actions github-actions bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Apr 4, 2021
@urkud urkud added awaiting-review The author would like community review of the PR blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. and removed WIP Work in progress blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Apr 4, 2021
@github-actions github-actions bot added merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Apr 6, 2021
@github-actions
Copy link

github-actions bot commented Apr 6, 2021

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Apr 6, 2021
@urkud urkud added WIP Work in progress and removed awaiting-review The author would like community review of the PR labels Apr 6, 2021
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Apr 22, 2021
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Jul 11, 2021
@urkud urkud added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Jul 13, 2021
@sgouezel
Copy link
Collaborator

bors r+
Thanks!

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jul 13, 2021
bors bot pushed a commit that referenced this pull request Jul 13, 2021
@urkud
feat(geometry/manifold): add charted_space and model_with_corners…
dd9a0ea 
… for pi types (#6578)

Also use `set.image2` in the `charted_space` instance for `model_prod`.
@bors
Copy link

bors bot commented Jul 13, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(geometry/manifold): add charted_space and model_with_corners for pi types [Merged by Bors] - feat(geometry/manifold): add charted_space and model_with_corners for pi types Jul 13, 2021
@bors bors bot closed this Jul 13, 2021
@bors bors bot deleted the charted-pi branch July 13, 2021 11:06
Vierkantor pushed a commit that referenced this pull request Jul 13, 2021
@urkud @Vierkantor
feat(geometry/manifold): add charted_space and model_with_corners…
7214d7b 
… for pi types (#6578)

Also use `set.image2` in the `charted_space` instance for `model_prod`.
b-mehta pushed a commit that referenced this pull request Jul 20, 2021
@urkud @b-mehta
feat(geometry/manifold): add charted_space and model_with_corners…
a0a6914 
… for pi types (#6578)

Also use `set.image2` in the `charted_space` instance for `model_prod`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@urkud @sgouezel