Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(field_theory/separable_degree): introduce the separable degree #6743

Closed
wants to merge 36 commits into from

Conversation

JakobScholbach
Copy link
Collaborator

@JakobScholbach JakobScholbach commented Mar 17, 2021

We introduce the definition of the separable degree of a polynomial. We prove that every irreducible polynomial can be contracted to a separable polynomial. We show that the separable degree divides the degree of the polynomial.
This formalizes a lemma in the Stacks Project, cf. https://stacks.math.columbia.edu/tag/09H0
We also show that the separable degree is unique.


@JakobScholbach JakobScholbach added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Mar 17, 2021
@github-actions github-actions bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Mar 17, 2021
@JakobScholbach JakobScholbach added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Mar 17, 2021
@bryangingechen
Copy link
Collaborator

@JakobScholbach If you'd like to mark this PR as dependent on another one, you should add something like the following to the end of the PR comment:

- [ ] depends on: #prnumber

Then a script will add the "blocked-by-other-PR" tag.

@github-actions github-actions bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Mar 17, 2021
@bryangingechen bryangingechen changed the title Separable degree feat(field_theory/separable_degree): introduce the separable degree Mar 17, 2021
Copy link
Member

@kbuzzard kbuzzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've only looked at the first file but I suggested a lot of code tidy_up/obfuscation/whatever you want to call it.

src/algebra/char_p/exp_char.lean Outdated Show resolved Hide resolved
src/algebra/char_p/exp_char.lean Outdated Show resolved Hide resolved
src/algebra/char_p/exp_char.lean Outdated Show resolved Hide resolved
src/algebra/char_p/exp_char.lean Outdated Show resolved Hide resolved
src/algebra/char_p/exp_char.lean Outdated Show resolved Hide resolved
src/algebra/char_p/exp_char.lean Outdated Show resolved Hide resolved
src/algebra/char_p/exp_char.lean Outdated Show resolved Hide resolved
src/algebra/char_p/exp_char.lean Outdated Show resolved Hide resolved
@github-actions github-actions bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Mar 18, 2021
@github-actions github-actions bot added merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Apr 1, 2021
@github-actions
Copy link

github-actions bot commented Apr 1, 2021

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Apr 2, 2021
@JakobScholbach JakobScholbach added the awaiting-review The author would like community review of the PR label Apr 14, 2021
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just two teeny-tiny style remarks.

bors d+

src/field_theory/separable_degree.lean Outdated Show resolved Hide resolved
src/field_theory/separable_degree.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Apr 14, 2021

✌️ JakobScholbach can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@JakobScholbach
Copy link
Collaborator Author

bors r+

@bors
Copy link

bors bot commented Apr 14, 2021

Canceled.

@JakobScholbach
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Apr 14, 2021
…6743)

We introduce the definition of the separable degree of a polynomial. We prove that every irreducible polynomial can be contracted to a separable polynomial. We show that the separable degree divides the degree of the polynomial.
This formalizes a lemma in the Stacks Project, cf. https://stacks.math.columbia.edu/tag/09H0 
We also show that the separable degree is unique.
@bors
Copy link

bors bot commented Apr 14, 2021

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Apr 14, 2021
…6743)

We introduce the definition of the separable degree of a polynomial. We prove that every irreducible polynomial can be contracted to a separable polynomial. We show that the separable degree divides the degree of the polynomial.
This formalizes a lemma in the Stacks Project, cf. https://stacks.math.columbia.edu/tag/09H0 
We also show that the separable degree is unique.
bors bot pushed a commit that referenced this pull request Apr 14, 2021
…6743)

We introduce the definition of the separable degree of a polynomial. We prove that every irreducible polynomial can be contracted to a separable polynomial. We show that the separable degree divides the degree of the polynomial.
This formalizes a lemma in the Stacks Project, cf. https://stacks.math.columbia.edu/tag/09H0 
We also show that the separable degree is unique.
@bors
Copy link

bors bot commented Apr 14, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(field_theory/separable_degree): introduce the separable degree [Merged by Bors] - feat(field_theory/separable_degree): introduce the separable degree Apr 14, 2021
@bors bors bot closed this Apr 14, 2021
@bors bors bot deleted the separable_degree branch April 14, 2021 23:14
@YaelDillies YaelDillies removed the awaiting-review The author would like community review of the PR label Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants