[Merged by Bors] - feat(order/ideal, order/pfilter, order/prime_ideal): added ideal_inter_nonempty, proved that a maximal ideal is prime

src/order/ideal.lean

@@ -14,15 +14,18 @@ import order.atoms
 
 Throughout this file, `P` is at least a preorder, but some sections require more
 structure, such as a bottom element, a top element, or a join-semilattice structure.
-
 - `order.ideal P`: the type of nonempty, upward directed, and downward closed subsets of `P`.
   Dual to the notion of a filter on a preorder.
 - `order.is_ideal P`: a predicate for when a `set P` is an ideal.
 - `order.ideal.principal p`: the principal ideal generated by `p : P`.
 - `order.ideal.is_proper P`: a predicate for proper ideals.
   Dual to the notion of a proper filter.
+- `order.ideal.is_prime`: a predicate for prime ideals.
+  Dual to the notion of a prime filter.
 - `order.ideal.is_maximal`: a predicate for maximal ideals.
   Dual to the notion of an ultrafilter.
+- `ideal_inter_nonempty P`: a predicate for when the intersection of any two ideals of
+  `P` is nonempty.
 - `order.cofinal P`: the type of subsets of `P` containing arbitrarily large elements.
   Dual to the notion of 'dense set' used in forcing.
 - `order.ideal_of_cofinals p 𝒟`, where `p : P`, and `𝒟` is a countable family of cofinal
@@ -72,10 +75,22 @@ structure ideal (P) [preorder P] :=
 def is_ideal.to_ideal [preorder P] {I : set P} (h : is_ideal I) : ideal P :=
 ⟨I, h.1, h.2, h.3⟩
 
+/-- A preorder `P` has the `ideal_inter_nonempty` property if the
+    intersection of any two ideals is nonempty.
+    Most importantly, a `semilattice_sup` preorder with this property
+    satisfies that its ideal poset is a lattice.
+-/
+class ideal_inter_nonempty (P) [preorder P] : Prop :=
+(inter_nonempty : ∀ (I J : ideal P), (I.carrier ∩ J.carrier).nonempty)
+
+lemma inter_nonempty [preorder P] [ideal_inter_nonempty P] :
+∀ (I J : ideal P), (I.carrier ∩ J.carrier).nonempty :=
+ideal_inter_nonempty.inter_nonempty
+
 namespace ideal
 
 section preorder
-variables [preorder P] {x : P} {I J : ideal P}
+variables [preorder P] {x y : P} {I J : ideal P}
 
 /-- The smallest ideal containing a given element. -/
 def principal (p : P) : ideal P :=
@@ -93,6 +108,10 @@ instance : has_coe (ideal P) (set P) := ⟨carrier⟩
 /-- For the notation `x ∈ I`. -/
 instance : has_mem P (ideal P) := ⟨λ x I, x ∈ (I : set P)⟩
 
+@[simp] lemma mem_def : x ∈ I ↔ x ∈ (I : set P) := iff_of_eq rfl
+
+@[simp] lemma mem_principal : y ∈ principal x ↔ y ≤ x := by refl
+
 /-- Two ideals are equal when their underlying sets are equal. -/
 @[ext] lemma ext : ∀ (I J : ideal P), (I : set P) = J → I = J
 | ⟨_, _, _, _⟩ ⟨_, _, _, _⟩ rfl := rfl
@@ -114,6 +133,9 @@ instance : partial_order (ideal P) := partial_order.lift coe ext
 ⟨λ (h : ∀ {y}, y ≤ x → y ∈ I), h (le_refl x),
  λ h_mem y (h_le : y ≤ x), I.mem_of_le h_le h_mem⟩
 
+lemma compl_mem_of_ge {x y : P} : x ≤ y → x ∈ (I : set P)ᶜ → y ∈ (I : set P)ᶜ :=
+λ h, mt (I.mem_of_le h)
+
 /-- A proper ideal is one that is not the whole set.
     Note that the whole set might not be an ideal. -/
 @[mk_iff] class is_proper (I : ideal P) : Prop := (ne_univ : (I : set P) ≠ set.univ)
@@ -129,7 +151,7 @@ end⟩
   Note that we cannot use the `is_coatom` class because `P` might not have a `top` element.
 -/
 @[mk_iff] class is_maximal (I : ideal P) extends is_proper I : Prop :=
-(maximal_proper : ∀ J : ideal P, I < J → J.carrier = set.univ)
+(maximal_proper : ∀ {J : ideal P}, I < J → J.carrier = set.univ)
 
 end preorder
 
@@ -191,7 +213,7 @@ lemma is_proper_iff_ne_top {I : ideal P} : is_proper I ↔ I ≠ ⊤ :=
 
 lemma is_maximal.is_coatom {I : ideal P} (h : is_maximal I) : is_coatom I :=
 ⟨is_maximal.to_is_proper.ne_top,
- λ J _, by { rw [ext'_iff, top_coe], exact is_maximal.maximal_proper J ‹_› }⟩
+ λ _ _, by { rw [ext'_iff, top_coe], exact is_maximal.maximal_proper ‹_› }⟩
 
 lemma is_maximal.is_coatom' {I : ideal P} [is_maximal I] : is_coatom I :=
 is_maximal.is_coatom ‹_›
@@ -219,20 +241,22 @@ I.mem_of_le (sup_le hx hy) h_mem
 
 end semilattice_sup
 
-section semilattice_sup_bot
-variables [semilattice_sup_bot P] (I J K : ideal P)
+section semilattice_sup_ideal_inter_nonempty
 
-/-- The intersection of two ideals is an ideal, when `P` has joins and a bottom. -/
+variables [semilattice_sup P] [ideal_inter_nonempty P]
+variables (I J K : ideal P)
+
+/-- The intersection of two ideals is an ideal, when it is nonempty and `P` has joins. -/
 def inf (I J : ideal P) : ideal P :=
 { carrier   := I ∩ J,
-  nonempty  := ⟨⊥, bot_mem, bot_mem⟩,
+  nonempty  := inter_nonempty I J,
   directed  := λ x ⟨_, _⟩ y ⟨_, _⟩, ⟨x ⊔ y, ⟨sup_mem x y ‹_› ‹_›, sup_mem x y ‹_› ‹_›⟩, by simp⟩,
   mem_of_le := λ x y h ⟨_, _⟩, ⟨mem_of_le I h ‹_›, mem_of_le J h ‹_›⟩ }
 
-/-- There is a smallest ideal containing two ideals, when `P` has joins and a bottom. -/
+/-- There is a smallest ideal containing two ideals, when it is nonempty and `P` has joins. -/
 def sup (I J : ideal P) : ideal P :=
 { carrier   := {x | ∃ (i ∈ I) (j ∈ J), x ≤ i ⊔ j},
-  nonempty  := ⟨⊥, ⊥, bot_mem, ⊥, bot_mem, bot_le⟩,
+  nonempty  := by {cases inter_nonempty I J, refine ⟨w, w, h.1, w, h.2, le_sup_left⟩},
   directed  := λ x ⟨xi, _, xj, _, _⟩ y ⟨yi, _, yj, _, _⟩,
     ⟨x ⊔ y,
      ⟨xi ⊔ yi, sup_mem xi yi ‹_› ‹_›,
@@ -251,8 +275,8 @@ K.mem_of_le hxij $ sup_mem i j (mem_of_mem_of_le hiI hIK) (mem_of_mem_of_le hjJ
 
 instance : lattice (ideal P) :=
 { sup          := sup,
-  le_sup_left  := λ I J (i ∈ I), ⟨i, ‹_›, ⊥, bot_mem, by simp only [sup_bot_eq]⟩,
-  le_sup_right := λ I J (j ∈ J), ⟨⊥, bot_mem, j, ‹_›, by simp only [bot_sup_eq]⟩,
+  le_sup_left  := λ I J (i ∈ I), by { cases nonempty J, refine ⟨i, ‹_›, w, ‹_›, le_sup_left⟩},
+  le_sup_right := λ I J (j ∈ J), by { cases nonempty I, refine ⟨w, ‹_›, j, ‹_›, le_sup_right⟩},
   sup_le       := sup_le,
   inf          := inf,
   inf_le_left  := λ I J, set.inter_subset_left I J,
@@ -264,8 +288,65 @@ instance : lattice (ideal P) :=
 
 @[simp] lemma mem_sup {x : P} : x ∈ I ⊔ J ↔ ∃ (i ∈ I) (j ∈ J), x ≤ i ⊔ j := iff_of_eq rfl
 
+lemma gt_sup_principal_of_not_mem {I : ideal P} {x : P} (hx : x ∉ I) : I < I ⊔ principal x :=
+begin
+  apply lt_of_le_of_ne le_sup_left,
+  intro h,
+  simp at h,
+  exact hx h
+end
+
+end semilattice_sup_ideal_inter_nonempty
+
+section semilattice_sup_bot
+variables [semilattice_sup_bot P] (I J K : ideal P)
+
+@[priority 100]
+instance semilattice_sup_bot.ideal_inter_nonempty : ideal_inter_nonempty P :=
+{ inter_nonempty := λ _ _, ⟨⊥, ⟨bot_mem, bot_mem⟩⟩ }
+
 end semilattice_sup_bot
 
+section semilattice_inf
+
+variable [semilattice_inf P]
+
+@[priority 100]
+instance semilattice_inf.ideal_inter_nonempty : ideal_inter_nonempty P :=
+{
+  inter_nonempty := λ I J, begin
+    cases I.nonempty with i _,
+    cases J.nonempty with j _,
+    exact ⟨i ⊓ j, I.mem_of_le inf_le_left ‹_›, J.mem_of_le inf_le_right ‹_›⟩
+  end
+}
+
+end semilattice_inf
+
+section distrib_lattice
+
+variables [distrib_lattice P]
+variables {I J : ideal P}
+
+lemma eq_sup_of_le_sup {x i j: P} (hi : i ∈ I) (hj : j ∈ J) (hx : x ≤ i ⊔ j):
+∃ (i' ∈ I) (j' ∈ J), x = i' ⊔ j' :=
+begin
+  refine ⟨x ⊓ i, I.mem_of_le inf_le_right hi, x ⊓ j, J.mem_of_le inf_le_right hj, _⟩,
+  calc
+  x    = x ⊓ (i ⊔ j) : left_eq_inf.mpr hx
+  ...  = (x ⊓ i) ⊔ (x ⊓ j) : inf_sup_left,
+end
+
+lemma sup_coe_eq_sup_set : ↑(I ⊔ J) = {x | ∃ i ∈ I, ∃ j ∈ J, x = i ⊔ j} :=
+begin
+  ext,
+  rw [← mem_def, mem_sup],
+  exact ⟨λ ⟨_, _, _, _, _⟩, eq_sup_of_le_sup ‹_› ‹_› ‹_›,
+  λ ⟨i, _, j, _, _⟩, ⟨i, ‹_›, j, ‹_›, le_of_eq ‹_›⟩⟩
+end
+
+end distrib_lattice
+
 end ideal
 
 /-- For a preorder `P`, `cofinal P` is the type of subsets of `P`

src/order/pfilter.lean

@@ -49,6 +49,10 @@ structure pfilter (P) [preorder P] :=
 def is_pfilter [preorder P] (F : set P) : Prop :=
 @is_ideal (order_dual P) _ F
 
+lemma is_pfilter.of_def [preorder P] {F : set P} (nonempty : F.nonempty)
+(directed : directed_on (≥) F) (mem_of_le : ∀ {x y : P}, x ≤ y → x ∈ F → y ∈ F) : is_pfilter F :=
+by { use [nonempty, directed], exact λ _ _ _ _, mem_of_le ‹_› ‹_›}
+
 /-- Create an element of type `order.pfilter` from a set satisfying the predicate
 `order.is_pfilter`. -/
 def is_pfilter.to_pfilter [preorder P] {F : set P} (h : is_pfilter F) : pfilter P :=
@@ -65,6 +69,8 @@ instance : has_coe (pfilter P) (set P) := ⟨λ F, F.dual.carrier⟩
 /-- For the notation `x ∈ F`. -/
 instance : has_mem P (pfilter P) := ⟨λ x F, x ∈ (F : set P)⟩
 
+@[simp] lemma mem_def : x ∈ F ↔ x ∈ (F : set P) := iff_of_eq rfl
+
 lemma is_pfilter : is_pfilter (F : set P) :=
 F.dual.is_ideal
 

src/order/prime_ideal.lean

@@ -31,14 +31,14 @@ ideal, prime
 
 -/
 
+open order.pfilter
+
 namespace order
 
 variables {P : Type*}
 
 section preorder
 
-variables [preorder P]
-
 namespace ideal
 
 /-- A pair of an `ideal` and a `pfilter` which form a partition of `P`.
@@ -50,6 +50,9 @@ structure prime_pair (P : Type*) [preorder P] :=
 (is_compl_I_F : is_compl (I : set P) F)
 
 namespace prime_pair
+
+variable [preorder P]
+
 variable (IF : prime_pair P)
 
 lemma compl_I_eq_F : (IF.I : set P)ᶜ = IF.F := IF.is_compl_I_F.compl_eq
@@ -71,9 +74,13 @@ end prime_pair
 
 /-- An ideal `I` is prime if its complement is a filter.
 -/
-@[mk_iff] class is_prime (I : ideal P) extends is_proper I : Prop :=
+@[mk_iff] class is_prime [preorder P] (I : ideal P) extends is_proper I : Prop :=
 (compl_filter : is_pfilter (I : set P)ᶜ)
 
+section preorder
+
+variable [preorder P]
+
 /-- Create an element of type `order.ideal.prime_pair` from an ideal satisfying the predicate
 `order.ideal.is_prime`. -/
 def is_prime.to_prime_pair {I : ideal P} (h : is_prime I) : prime_pair P :=
@@ -85,10 +92,76 @@ lemma prime_pair.I_is_prime (IF : prime_pair P) : is_prime IF.I :=
 { compl_filter := by { rw IF.compl_I_eq_F, exact IF.F.is_pfilter },
   ..IF.I_is_proper }
 
+end preorder
+
+section semilattice_inf
+
+variable [semilattice_inf P]
+
+variables {x y : P} {I : ideal P}
+
+lemma is_prime.mem_or_mem (hI : is_prime I) {x y : P} : x ⊓ y ∈ I → x ∈ I ∨ y ∈ I :=
+begin
+  contrapose!,
+  let F := hI.compl_filter.to_pfilter,
+  show x ∈ F ∧ y ∈ F → x ⊓ y ∈ F,
+  exact λ h, inf_mem _ _ h.1 h.2,
+end
+
+lemma is_prime.of_mem_or_mem [is_proper I] (hI : ∀ {x y : P}, x ⊓ y ∈ I → x ∈ I ∨ y ∈ I) :
+is_prime I :=
+begin
+  rw is_prime_iff,
+  use ‹_›,
+  apply is_pfilter.of_def,
+  { exact set.nonempty_compl.2 (I.is_proper_iff.1 ‹_›) },
+  { intros x _ y _,
+    refine ⟨x ⊓ y, _, inf_le_left, inf_le_right⟩,
+    have := mt hI,
+    tauto!,
+   },
+  { exact @compl_mem_of_ge _ _ _}
+end
+
+lemma is_prime_iff_mem_or_mem [is_proper I] : is_prime I ↔ ∀ {x y : P}, x ⊓ y ∈ I → x ∈ I ∨ y ∈ I :=
+⟨is_prime.mem_or_mem, is_prime.of_mem_or_mem⟩
+
+end semilattice_inf
+
+section distrib_lattice
+
+variables [distrib_lattice P]
+variables {I : ideal P}
+
+@[priority 100]
+instance is_maximal.is_prime [is_maximal I] : is_prime I :=
+begin
+  rw is_prime_iff_mem_or_mem,
+  intros x y,
+  contrapose!,
+  rintro ⟨hx, hynI⟩ hxy,
+  apply hynI,
+  let J := I ⊔ principal x,
+  have hJuniv : (J : set P) = set.univ :=
+  is_maximal.maximal_proper (gt_sup_principal_of_not_mem ‹_›),
+  have hyJ : y ∈ ↑J := set.eq_univ_iff_forall.mp hJuniv y,
+  rw sup_coe_eq_sup_set at hyJ,
+  rcases hyJ with ⟨a, ha, b, hb, hy⟩,
+  rw hy,
+  apply sup_mem _ _ ha,
+  refine I.mem_of_le (le_inf hb _) hxy,
+  rw hy,
+  exact le_sup_right
+end
+
+end distrib_lattice
+
 end ideal
 
 namespace pfilter
 
+variable [preorder P]
+
 /-- A filter `F` is prime if its complement is an ideal.
 -/
 @[mk_iff] class is_prime (F : pfilter P) : Prop :=