Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

[Merged by Bors] - feat(data/nat/fib): add a strict monotonicity lemma. #7317

Closed
wants to merge 1 commit into from

Conversation

Julian
Copy link
Collaborator

@Julian Julian commented Apr 21, 2021

Prove strict monotonicity of fib (n + 2).

With thanks to @b-mehta and @dwarn.


I suspect it's highly likely I didn't name the lemma appropriately (or that there are other suggestions for improving things) which are of course very welcome.

Open in Gitpod

@Julian Julian force-pushed the fib-strict-mono branch 2 times, most recently from 8a9e9ca to 38bbe7e Compare April 21, 2021 21:17
@Julian Julian changed the title feat(data/fib): add a strict monotonicity lemma. feat(data/nat/fib): add a strict monotonicity lemma. Apr 21, 2021
@bryangingechen bryangingechen added the awaiting-author A reviewer has asked the author a question or requested changes label Apr 22, 2021
@Julian Julian added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Apr 22, 2021
Copy link
Collaborator

@benjamindavidson benjamindavidson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I don't know whether or not this lemma ought to be labeled with @[mono].

@Julian
Copy link
Collaborator Author

Julian commented Apr 22, 2021

Lean made fun of me with quite an interesting error message when I tried adding it, so I figured the answer was "no". Specifically, it quizzically emits:

oh? strict_mono.{0 0} nat nat nat.has_lt nat.has_lt (fun (n : nat), (nat.fib (has_add.add.{0} nat nat.has_add n (bit0.{0} nat nat.has_add (has_one.one.{0} nat nat.has_one)))))

and yes with the oh? part of the error message :D

@kim-em
Copy link
Collaborator

kim-em commented Apr 25, 2021

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Apr 25, 2021
bors bot pushed a commit that referenced this pull request Apr 25, 2021
Prove strict monotonicity of `fib (n + 2)`.

With thanks to @b-mehta and @dwarn.
@bors
Copy link

bors bot commented Apr 25, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/nat/fib): add a strict monotonicity lemma. [Merged by Bors] - feat(data/nat/fib): add a strict monotonicity lemma. Apr 25, 2021
@bors bors bot closed this Apr 25, 2021
@bors bors bot deleted the fib-strict-mono branch April 25, 2021 20:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants