This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 298
[Merged by Bors] - feat(data/nat/fib): add a strict monotonicity lemma. #7317
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julian
force-pushed
the
fib-strict-mono
branch
2 times, most recently
from
April 21, 2021 21:17
8a9e9ca
to
38bbe7e
Compare
Julian
changed the title
feat(data/fib): add a strict monotonicity lemma.
feat(data/nat/fib): add a strict monotonicity lemma.
Apr 21, 2021
bryangingechen
added
the
awaiting-author
A reviewer has asked the author a question or requested changes
label
Apr 22, 2021
Julian
added
awaiting-review
The author would like community review of the PR
and removed
awaiting-author
A reviewer has asked the author a question or requested changes
labels
Apr 22, 2021
benjamindavidson
approved these changes
Apr 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I don't know whether or not this lemma ought to be labeled with @[mono]
.
Lean made fun of me with quite an interesting error message when I tried adding it, so I figured the answer was "no". Specifically, it quizzically emits:
and yes with the |
bors merge |
github-actions
bot
added
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
and removed
awaiting-review
The author would like community review of the PR
labels
Apr 25, 2021
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
feat(data/nat/fib): add a strict monotonicity lemma.
[Merged by Bors] - feat(data/nat/fib): add a strict monotonicity lemma.
Apr 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prove strict monotonicity of
fib (n + 2)
.With thanks to @b-mehta and @dwarn.
I suspect it's highly likely I didn't name the lemma appropriately (or that there are other suggestions for improving things) which are of course very welcome.