[Merged by Bors] - chore(data/set/intervals): relax linear_order to preorder in the proofs of Ixx_eq_empty_iff
#8071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaelDillies
added
the
awaiting-review
eric-wieser
reviewed
Jun 24, 2021
eric-wieser
reviewed
Jun 24, 2021
github-actions
bot
added
the
merge-conflict
github-actions
bot
removed
the
merge-conflict
eric-wieser
reviewed
Jun 27, 2021
eric-wieser
reviewed
Jun 27, 2021
eric-wieser
reviewed
Jun 27, 2021
eric-wieser
reviewed
Jun 27, 2021
eric-wieser
changed the title
Ixx_eq_emptyIxx_eq_empty_iff
eric-wieser
reviewed
Jun 27, 2021
eric-wieser
reviewed
Jun 27, 2021
|
Thanks 🎉 bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jul 13, 2021
…fs of `Ixx_eq_empty_iff` (#8071) The previous formulations of `Ixx_eq_empty(_iff)` are basically a chaining of this formulation plus `not_lt` or `not_le`. But `not_lt` and `not_le` require `linear_order`. Removing them allows relaxing the typeclasses assumptions on `Ixx_eq_empty_iff` and slightly generalising `Ixx_eq_empty`.
|
Build failed: |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jul 13, 2021
…fs of `Ixx_eq_empty_iff` (#8071) The previous formulations of `Ixx_eq_empty(_iff)` are basically a chaining of this formulation plus `not_lt` or `not_le`. But `not_lt` and `not_le` require `linear_order`. Removing them allows relaxing the typeclasses assumptions on `Ixx_eq_empty_iff` and slightly generalising `Ixx_eq_empty`.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Ixx_eq_empty_iffIxx_eq_empty_iff
b-mehta
pushed a commit
that referenced
this pull request
Jul 20, 2021
…fs of `Ixx_eq_empty_iff` (#8071) The previous formulations of `Ixx_eq_empty(_iff)` are basically a chaining of this formulation plus `not_lt` or `not_le`. But `not_lt` and `not_le` require `linear_order`. Removing them allows relaxing the typeclasses assumptions on `Ixx_eq_empty_iff` and slightly generalising `Ixx_eq_empty`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous formulations of
Ixx_eq_empty(_iff)are basically a chaining of this formulation plusnot_ltornot_le. Butnot_ltandnot_lerequirelinear_order. Removing them allows relaxing the typeclasses assumptions onIxx_eq_empty_iffand slightly generalisingIxx_eq_empty.