Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(data/set/intervals): syntax clean up #8087

Closed
wants to merge 2 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented Jun 26, 2021


Don't mind me, I'm a bit obsessed with with cleanliness.

This is to declutter the diff of #8071.
Open in Gitpod

@YaelDillies YaelDillies added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR labels Jun 26, 2021
@YaelDillies
Copy link
Collaborator Author

Oh sorry I just notice now that I didn't only change le_refl _ to le_rfl. But I guess that's fine?

Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

I'm not sure mathlib style takes a stance on whether trailing commas are good or bad, so it's probably best to avoid changing those in future unless the style guide is changed to state an opinion.

There's enough nice cleanup in here to offset any quibbles about commas though, and it's not worth spending more time on this.

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jun 26, 2021
bors bot pushed a commit that referenced this pull request Jun 26, 2021
@bors
Copy link

bors bot commented Jun 26, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(data/set/intervals): syntax clean up [Merged by Bors] - chore(data/set/intervals): syntax clean up Jun 26, 2021
@bors bors bot closed this Jun 26, 2021
@bors bors bot deleted the yael/setintervals branch June 26, 2021 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants