[Merged by Bors] - feat(data/ordmap/ordset): Implement some more ordset functions
#8127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`src/data/ordmap` along with a few useful related proofs.
bryangingechen
added
the
awaiting-review
|
Thank you very much, I know those proofs are a bit tricky. This is a very nice first contribution, and I don't see any style issues. A good follow-up would be to prove that mem actually finds elements when they are there (i.e. equivalence of bors r+ |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jun 29, 2021
Implement (with proofs) `erase`, `map`, and `mem` for `ordset` in `src/data/ordmap` along with a few useful related proofs.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
ordset functionsordset functions
b-mehta
pushed a commit
that referenced
this pull request
Jul 6, 2021
Implement (with proofs) `erase`, `map`, and `mem` for `ordset` in `src/data/ordmap` along with a few useful related proofs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement (with proofs)
erase,map, andmemforordsetinsrc/data/ordmapalong with a few useful related proofs.I've tried my best to follow the contributing guide but please let me know if any improvements or changes should be made.
Reopen of #8096.