Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(ring_theory): is_dedekind_domain_inv implies is_dedekind_domain #8315

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - feat(ring_theory): is_dedekind_domain_inv implies is_dedekind_domain #8315

wants to merge 6 commits into from

Conversation

Vierkantor
Copy link
Collaborator

@Vierkantor Vierkantor commented Jul 14, 2021 •
edited by github-actions bot
Loading

@Vierkantor Vierkantor added awaiting-review The author would like community review of the PR blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Jul 14, 2021
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Jul 20, 2021
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Jul 20, 2021
@Vierkantor Vierkantor mentioned this pull request Jul 22, 2021
Closed
2 tasks
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Jul 22, 2021
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Jul 22, 2021
jcommelin
jcommelin reviewed Jul 26, 2021
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

src/ring_theory/dedekind_domain.lean Outdated Show resolved Hide resolved
src/ring_theory/dedekind_domain.lean Outdated Show resolved Hide resolved
@github-actions github-actions bot added merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Jul 26, 2021
@github-actions
Copy link

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Jul 26, 2021
jcommelin
jcommelin approved these changes Jul 27, 2021
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors d+

src/ring_theory/dedekind_domain.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Jul 27, 2021

✌️ Vierkantor can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jul 27, 2021
@Vierkantor
Copy link
Collaborator Author

bors r+

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Jul 27, 2021
bors bot pushed a commit that referenced this pull request Jul 27, 2021
@Vierkantor
feat(ring_theory): is_dedekind_domain_inv implies `is_dedekind_doma…
aea21af 
…in` (#8315)

Co-Authored-By: Ashvni ashvni.n@gmail.com
Co-Authored-By: Filippo A. E. Nuccio filippo.nuccio@univ-st-etienne.fr
@bors
Copy link

bors bot commented Jul 27, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(ring_theory): is_dedekind_domain_inv implies is_dedekind_domain [Merged by Bors] - feat(ring_theory): is_dedekind_domain_inv implies is_dedekind_domain Jul 27, 2021
@bors bors bot closed this Jul 27, 2021
@bors bors bot deleted the dd_inv_iff branch July 27, 2021 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
Dedekind domains
Awaiting triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Vierkantor @jcommelin