Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(ring_theory): define fractional_ideal.adjoin_integral #8296

Closed
wants to merge 2 commits into from

Conversation

Vierkantor
Copy link
Collaborator

This PR shows if x is integral over R, then R[x] is a fractional ideal, and proves some of the essential properties of this fractional ideal.

This is an important step towards showing is_dedekind_domain_inv implies that the ring is integrally closed.

Co-Authored-By: Ashvni ashvni.n@gmail.com
Co-Authored-By: Filippo A. E. Nuccio filippo.nuccio@univ-st-etienne.fr


Open in Gitpod

This PR shows if `x` is integral over `R`, then `R[x]` is a fractional ideal,
and proves some of the essential properties of this fractional ideal.

This is an important step towards showing `is_dedekind_domain_inv` implies
that the ring is integrally closed.

Co-Authored-By: Ashvni ashvni.n@gmail.com
Co-Authored-By: Filippo A. E. Nuccio filippo.nuccio@univ-st-etienne.fr
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, sorry for missing this PR 🙈
LGTM

bors d+

src/ring_theory/fractional_ideal.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Jul 20, 2021

✌️ Vierkantor can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jul 20, 2021
@Vierkantor
Copy link
Collaborator Author

bors r+

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Jul 20, 2021
bors bot pushed a commit that referenced this pull request Jul 20, 2021
This PR shows if `x` is integral over `R`, then `R[x]` is a fractional ideal, and proves some of the essential properties of this fractional ideal.

This is an important step towards showing `is_dedekind_domain_inv` implies that the ring is integrally closed.

Co-Authored-By: Ashvni ashvni.n@gmail.com
Co-Authored-By: Filippo A. E. Nuccio filippo.nuccio@univ-st-etienne.fr
@bors
Copy link

bors bot commented Jul 20, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(ring_theory): define fractional_ideal.adjoin_integral [Merged by Bors] - feat(ring_theory): define fractional_ideal.adjoin_integral Jul 20, 2021
@bors bors bot closed this Jul 20, 2021
@bors bors bot deleted the fractional_ideal-adjoin_integral branch July 20, 2021 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
Dedekind domains
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

2 participants