This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 298
[Merged by Bors] - feat(linear_algebra/matrix/determinant): generalize det_fin_zero to det_eq_one_of_is_empty #8387
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et_eq_one_of_is_empty Also golfs a nearby proof
eric-wieser
added
the
awaiting-review
The author would like community review of the PR
label
Jul 21, 2021
Vierkantor
reviewed
Jul 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tried showing det_eq_one_of_is_empty
directly? Ideally it would be at least as easy as det_eq_one_of_card_eq_zero
, so if it is more difficult that would suggest that there are some missing lemmas.
The generalization looks good to me otherwise.
We were missing the |
eric-wieser
commented
Jul 22, 2021
eric-wieser
commented
Jul 22, 2021
Vierkantor
approved these changes
Jul 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for fixing all the dependencies!
bors r+
github-actions
bot
added
the
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
label
Jul 22, 2021
bors bot
pushed a commit
that referenced
this pull request
Jul 22, 2021
…et_eq_one_of_is_empty (#8387) Also golfs a nearby proof
github-actions
bot
removed
the
awaiting-review
The author would like community review of the PR
label
Jul 22, 2021
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
feat(linear_algebra/matrix/determinant): generalize det_fin_zero to det_eq_one_of_is_empty
[Merged by Bors] - feat(linear_algebra/matrix/determinant): generalize det_fin_zero to det_eq_one_of_is_empty
Jul 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also golfs a nearby proof