[Merged by Bors] - feat(data/matrix/basic): provide equiv versions of matrix.map, linear_map.map_matrix, and ring_hom.map_matrix.
#8468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ear_map.map_matrix`, and `ring_hom.map_matrix`. This moves all of these definitions to be adjacent, adds the standard family of functorial simp lemmas, and relaxes some typeclass requirements.
eric-wieser
added
the
awaiting-review
Vierkantor
approved these changes
Aug 2, 2021
Vierkantor
added
awaiting-author
|
If we merge #8486 before this one, then I'll update this with the alg_hom versions too |
Vierkantor
added a commit
that referenced
this pull request
Aug 2, 2021
These can already be found by `simp` since `matrix.map_zero` is a `simp` lemma, and we can manually use `foo_hom.map_matrix.map_zero` introduced by #8468 instead.
github-actions
bot
added
ready-to-merge
|
Oops, missed the build failure. bors r- |
|
Canceled. |
|
bors d+ |
|
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
the
delegated
|
What build failure? |
|
It looks like by pushing your branch you confused github, but https://github.com/leanprover-community/mathlib/actions/runs/1082117908 seems happy. |
|
Ah, that's why I didn't notice the build failure :P Nevermind then! bors r+ |
I'll do the alg_hom versions in a follow-up PR instead. |
bors bot
pushed a commit
that referenced
this pull request
Aug 2, 2021
…ear_map.map_matrix`, and `ring_hom.map_matrix`. (#8468) This moves all of these definitions to be adjacent, adds the standard family of functorial simp lemmas, and relaxes some typeclass requirements. This also renames `matrix.one_map` to `matrix.map_one` to match `matrix.map_zero`.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
matrix.map, linear_map.map_matrix, and ring_hom.map_matrix.matrix.map, linear_map.map_matrix, and ring_hom.map_matrix.
Vierkantor
added a commit
that referenced
this pull request
Aug 2, 2021
These can already be found by `simp` since `matrix.map_zero` is a `simp` lemma, and we can manually use `foo_hom.map_matrix.map_zero` introduced by #8468 instead.
bors bot
pushed a commit
that referenced
this pull request
Aug 2, 2021
These can already be found by `simp` since `matrix.map_zero` is a `simp` lemma, and we can manually use `foo_hom.map_matrix.map_zero` introduced by #8468 instead. They also don't seem to be used anywhere in mathlib, given that deleting them with no replacement causes no build errors. Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves all of these definitions to be adjacent, adds the standard family of functorial simp lemmas, and relaxes some typeclass requirements.
This also renames
matrix.one_maptomatrix.map_oneto matchmatrix.map_zero.