[Merged by Bors] - refactor(data/matrix/basic): merge duplicate algebra structures #8486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
force-pushed
the
eric-wieser/move-matrix-algebra
branch
from
06cd890
to
68c2784
Compare
eric-wieser
changed the title
eric-wieser
added
the
awaiting-review
Vierkantor
reviewed
Aug 2, 2021
Vierkantor
added
awaiting-author
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
eric-wieser
added
awaiting-review
|
bors d+ |
|
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
|
bors r+ |
github-actions
bot
added
the
ready-to-merge
|
Canceled. |
eric-wieser
force-pushed
the
eric-wieser/move-matrix-algebra
branch
from
628cd0e
to
7ec6d40
Compare
|
bors r+ |
This was referenced Aug 2, 2021
bors bot
pushed a commit
that referenced
this pull request
Aug 2, 2021
By putting the algebra instance in the same file as `scalar`, a future patch can probably remove `matrix.scalar` entirely (it's just another spelling of `algebra_map`). Note that we actually had two instances of `algebra R (matrix n n R)` in different files, and the second one was strictly more general than the first. This removes the less general one. Moving the imports around like this changes the number of simp lemmas available in downstream files, which can make `simp` slow enough to push a proof into a timeout. A lot of files were expecting a transitive import of `algebra.algebra.basic` to import `data.fintype.card`, which it no longer does; hence the need to add this import explicitly. There are no new lemmas or generalizations in this change; the old `matrix_algebra` has been deleted, and everything else has been moved with some variables renamed.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By putting the algebra instance in the same file as
scalar, a future patch can probably removematrix.scalarentirely (it's just another spelling ofalgebra_map).Note that we actually had two instances of
algebra R (matrix n n R)in different files, and the second one was strictly more general than the first. This removes the less general one.Moving the imports around like this changes the number of simp lemmas available in downstream files, which can make
simpslow enough to push a proof into a timeout.A lot of files were expecting a transitive import of
algebra.algebra.basicto importdata.fintype.card, which it no longer does; hence the need to add this import explicitly.There are no new lemmas or generalizations in this change; the old
matrix_algebrahas been deleted, and everything else has been moved with some variables renamed.