Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(linear_algebra/dimension): generalize dim_map_le to heterogeneous universes #8800

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat(linear_algebra/dimension): generalize dim_map_le to heterogeneous universes #8800

wants to merge 3 commits into from

Conversation

semorrison
Copy link
Collaborator

@fpvandoorn fpvandoorn mentioned this pull request Aug 22, 2021
Closed
1 task
@semorrison semorrison added the awaiting-review The author would like community review of the PR label Aug 23, 2021
@fpvandoorn fpvandoorn added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Aug 23, 2021
@semorrison semorrison added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Aug 24, 2021
@fpvandoorn
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Aug 24, 2021
bors bot pushed a commit that referenced this pull request Aug 24, 2021
@semorrison
feat(linear_algebra/dimension): generalize dim_map_le to heterogeneou…
737b208 
…s universes (#8800)

Per @hrmacbeth's [request on zulip](https://leanprover.zulipchat.com/#narrow/stream/217875-Is-there.20code.20for.20X.3F/topic/Behaviour.20of.20finrank.20under.20morphisms).
@bors
Copy link

bors bot commented Aug 24, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(linear_algebra/dimension): generalize dim_map_le to heterogeneous universes [Merged by Bors] - feat(linear_algebra/dimension): generalize dim_map_le to heterogeneous universes Aug 24, 2021
@bors bors bot closed this Aug 24, 2021
@bors bors bot deleted the lift_dim_map_le branch August 24, 2021 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpvandoorn fpvandoorn fpvandoorn left review comments

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@semorrison @fpvandoorn