Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(linear_algebra/finite_dimensional): add finrank_map_le #8815

Closed
wants to merge 5 commits into from

Conversation

fpvandoorn
Copy link
Member

@fpvandoorn fpvandoorn commented Aug 22, 2021

@fpvandoorn fpvandoorn added the awaiting-review The author would like community review of the PR label Aug 22, 2021
@github-actions github-actions bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Aug 22, 2021
@hrmacbeth
Copy link
Member

hrmacbeth commented Aug 23, 2021

The finrank equality case is pretty easy if you want it -- not sure how to generalize to the version with dims and cardinals:

lemma finrank_map_linear_equiv_eq (f : V ≃ₗ[K] V) (p : submodule K V) [finite_dimensional K p] :
  finrank K (p.map (f : V →ₗ[K] V)) = finrank K p :=
begin
  refine le_antisymm _ _,
  { exact finrank_map_le K (f : V →ₗ[K] V) p },
  { have : p = (p.map (f : V →ₗ[K] V)).map f.symm,
    { simp [← p.map_comp (f : V →ₗ[K] V) (f.symm : V →ₗ[K] V)] },
    convert finrank_map_le K (f.symm : V →ₗ[K] V) (p.map f) }
end

@fpvandoorn
Copy link
Member Author

Ok, I'll add that to this PR (with the codomain replaced by V₂)

@fpvandoorn
Copy link
Member Author

fpvandoorn commented Aug 23, 2021

Your lemma is also proven by (f.of_submodule p).finrank_eq.symm. Do you think it's still worth having?

@hrmacbeth
Copy link
Member

Oh, nice! I think it's worth having, since the short proof you found is non-obvious, but obviously use the short proof.

@github-actions github-actions bot added merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Aug 24, 2021
@github-actions
Copy link

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Aug 24, 2021
@ChrisHughes24
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Aug 25, 2021
bors bot pushed a commit that referenced this pull request Aug 25, 2021
Co-authored-by: Scott Morrison <scott@tqft.net>
@bors
Copy link

bors bot commented Aug 25, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(linear_algebra/finite_dimensional): add finrank_map_le [Merged by Bors] - feat(linear_algebra/finite_dimensional): add finrank_map_le Aug 25, 2021
@bors bors bot closed this Aug 25, 2021
@bors bors bot deleted the fin_dim_map branch August 25, 2021 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants