[Merged by Bors] - feat(algebra/module/ordered): redefine ordered_module as ordered_smul
#8930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pechersky
added
awaiting-review
github-actions
bot
added
the
blocked-by-other-PR
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
…ky/ordered-module-smul
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
…ky/ordered-module-smul
github-actions
bot
removed
the
blocked-by-other-PR
|
🎉 Great news! Looks like all the dependencies have been resolved: 💡 To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
pechersky
added
awaiting-review
jcommelin
reviewed
Sep 2, 2021
github-actions
bot
added
the
merge-conflict
pechersky
changed the title
ordered_module to smul_with_zeroordered_module as ordered_smul
github-actions
bot
removed
the
merge-conflict
github-actions
bot
added
the
merge-conflict
github-actions
bot
removed
the
merge-conflict
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Sep 6, 2021
…mul` (#8930) One would like to talk about `ordered_monoid R (with_top R)`, but the `module` constraint is too strict to allow this. The definition of `ordered_monoid` works if it is loosened to `has_scalar R M`. Most of the proofs that are part of its API need at most `smul_with_zero`. So it has been loosened to `smul_with_zero`, since a lawless `ordered_monoid` wouldn't do much. In the `ordered_field` portion, `module` has been loosened to `mul_action_with_zero`. `order_dual` instances of `smul` instances have also been generalized to better transmit. There are more generalizations possible, but seem out of scope for a single PR. Unfortunately, these generalizations exposed a gnarly misalignment between `prod.has_lt` and `prod.has_le`, which have incompatible definitions, when inferred through separate paths. In particular, the `lt` definition of generated by `prod.preorder` is different than the core `prod.has_lt`. Due to this, the `prod.ordered_monoid` instance has not been generalized. Co-authored-by: Yakov Pechersky <pechersky@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
ordered_module as ordered_smulordered_module as ordered_smul
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One would like to talk about
ordered_monoid R (with_top R), but themoduleconstraint is too strict to allow this.The definition of
ordered_monoidworks if it is loosened tohas_scalar R M. Most of the proofs that are part of its API need at mostsmul_with_zero. So it has been loosened tosmul_with_zero, since a lawlessordered_monoidwouldn't do much.In the
ordered_fieldportion,modulehas been loosened tomul_action_with_zero.order_dualinstances ofsmulinstances have also been generalized to better transmit. There are more generalizations possible, but seem out of scope for a single PR.Unfortunately, these generalizations exposed a gnarly misalignment between
prod.has_ltandprod.has_le, which have incompatible definitions, when inferred through separate paths. In particular, theltdefinition of generated byprod.preorderis different than the coreprod.has_lt. Due to this, theprod.ordered_monoidinstance has not been generalized.