Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(order/basic): recursor for order_dual #8938

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat(order/basic): recursor for order_dual #8938

wants to merge 4 commits into from

Conversation

pechersky
Copy link
Collaborator

Open in Gitpod

@pechersky pechersky mentioned this pull request Aug 31, 2021
Closed
1 task
@pechersky pechersky added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Aug 31, 2021
eric-wieser
eric-wieser reviewed Aug 31, 2021
View reviewed changes
src/order/basic.lean Outdated Show resolved Hide resolved
@eric-wieser eric-wieser added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Aug 31, 2021
@pechersky pechersky added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Aug 31, 2021
@pechersky @eric-wieser
Update src/order/order_dual.lean
4673672 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@pechersky @eric-wieser
Update src/order/order_dual.lean
7cfede4 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
eric-wieser
eric-wieser approved these changes Sep 1, 2021
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Sep 1, 2021
bors bot pushed a commit that referenced this pull request Sep 1, 2021
@pechersky
feat(order/basic): recursor for order_dual (#8938)
5bb61c3 
Co-authored-by: Yakov Pechersky <pechersky@users.noreply.github.com>
@bors
Copy link

bors bot commented Sep 1, 2021

Build failed:

@eric-wieser
Copy link
Member

bors merge

@eric-wieser eric-wieser closed this Sep 1, 2021
@bors
Copy link

bors bot commented Sep 1, 2021

Already running a review

@eric-wieser eric-wieser reopened this Sep 1, 2021
@eric-wieser
Copy link
Member

bors merge

bors bot pushed a commit that referenced this pull request Sep 1, 2021
@pechersky
feat(order/basic): recursor for order_dual (#8938)
d472e1b 
Co-authored-by: Yakov Pechersky <pechersky@users.noreply.github.com>
@bors
Copy link

bors bot commented Sep 1, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(order/basic): recursor for order_dual [Merged by Bors] - feat(order/basic): recursor for order_dual Sep 1, 2021
@bors bors bot closed this Sep 1, 2021
@bors bors bot deleted the pechersky/dual-rec branch September 1, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pechersky @eric-wieser