[Merged by Bors] - refactor(algebra/module/linear_map): Move elementwise structure from linear_algebra/basic #9331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…linear_algebra/basic This helps reduce the size of linear_algebra/basic, and by virtue of being a smaller file makes it easier to spot typeclasses which can be relaxed. In particular, `linear_map.endomorphism_ring` now requires only `semiring R` not `ring R`.
eric-wieser
added
the
awaiting-CI
eric-wieser
added
awaiting-review
|
I wouldn't normally do this, but is there any chance this could wait until after #9272 is merged? It looks like it won't be too long now, and having to keep up with major refactors in |
|
I've split out the non-major-refactor part of this PR as #9335 |
github-actions
bot
added
the
blocked-by-other-PR
Thanks a lot! |
github-actions
bot
added
merge-conflict
github-actions
bot
removed
the
merge-conflict
github-actions
bot
added
blocked-by-other-PR
…_map-arithmetic # Conflicts: # src/algebra/module/linear_map.lean # src/linear_algebra/basic.lean
github-actions
bot
removed
the
blocked-by-other-PR
|
🎉 Great news! Looks like all the dependencies have been resolved:
💡 To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
github-actions
bot
removed
the
merge-conflict
eric-wieser
commented
Sep 29, 2021
|
bors merge |
github-actions
bot
added
the
ready-to-merge
github-actions
bot
removed
the
awaiting-review
bors bot
pushed a commit
that referenced
this pull request
Sep 30, 2021
…linear_algebra/basic (#9331) This helps reduce the size of linear_algebra/basic, and by virtue of being a smaller file makes it easier to spot typeclasses which can be relaxed. As an example, `linear_map.endomorphism_ring` now requires only `semiring R` not `ring R`. Having instances available as early as possible is generally good, as otherwise it is hard to even state things elsewhere.
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Sep 30, 2021
…linear_algebra/basic (#9331) This helps reduce the size of linear_algebra/basic, and by virtue of being a smaller file makes it easier to spot typeclasses which can be relaxed. As an example, `linear_map.endomorphism_ring` now requires only `semiring R` not `ring R`. Having instances available as early as possible is generally good, as otherwise it is hard to even state things elsewhere.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps reduce the size of linear_algebra/basic, and by virtue of being a smaller file makes it easier to spot typeclasses which can be relaxed.
As an example,
linear_map.endomorphism_ringnow requires onlysemiring Rnotring R.Having instances available as early as possible is generally good, as otherwise it is hard to even state things elsewhere.
linear_map.neg_comp, generalizelinear_map.{sub,smul}_comp#9335linear_map.add_comm_groupto semilinear maps #9402