Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - fix(linear_algebra/basic): generalize linear_map.add_comm_group to semilinear maps #9402

Closed
wants to merge 2 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Sep 27, 2021

Also generalizes coe_mk and golfs some proofs.


Open in Gitpod

Split from #9331

Copy link
Collaborator

@dupuisf dupuisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thanks!

@eric-wieser eric-wieser added the easy < 20s of review time. See the lifecycle page for guidelines. label Sep 28, 2021
@semorrison
Copy link
Collaborator

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Sep 29, 2021
bors bot pushed a commit that referenced this pull request Sep 29, 2021
…semilinear maps (#9402)

Also generalizes `coe_mk` and golfs some proofs.
@bors
Copy link

bors bot commented Sep 29, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title fix(linear_algebra/basic): generalize linear_map.add_comm_group to semilinear maps [Merged by Bors] - fix(linear_algebra/basic): generalize linear_map.add_comm_group to semilinear maps Sep 29, 2021
@bors bors bot closed this Sep 29, 2021
@bors bors bot deleted the eric-wieser/golf-linear_map branch September 29, 2021 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants