-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add TC cycles #2030
Comments
One thing to note here is that loops which have data in are still potentially dangerous I believe. It doesn't look like this affects Yury's examples, but for example one might want the instance that a finite integral domain is a field, as this instance presumably will construct the |
Related: #6646 There are still mysterious issues impairing performance even for Prop-valued classes. (See also Zulip) |
@alexjbest Indeed, I'm talking about |
In Lean 3, many lemmas are not instances to avoid loops. I think that we should not turn them into instances while porting. Instead, we should turn them into instances all at once after the port is done and see how does it affect build time. For now, we should create a list of these lemmas.
normalOfCompactT2
;T3Space.mk
(any T₀ regular space is a T₃ space);normalSpaceOfT3SecondCountable
;compact_t2_tot_disc_iff_tot_sep
(theIff.mp
implication);loc_compact_t2_tot_disc_iff_tot_sep
;UniformSpace.secondCountable_of_separable
The text was updated successfully, but these errors were encountered: