Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add TC cycles #2030

Open
1 of 6 tasks
urkud opened this issue Feb 3, 2023 · 3 comments
Open
1 of 6 tasks

refactor: add TC cycles #2030

urkud opened this issue Feb 3, 2023 · 3 comments

Comments

@urkud
Copy link
Member

urkud commented Feb 3, 2023

In Lean 3, many lemmas are not instances to avoid loops. I think that we should not turn them into instances while porting. Instead, we should turn them into instances all at once after the port is done and see how does it affect build time. For now, we should create a list of these lemmas.

  • normalOfCompactT2;
  • T3Space.mk (any T₀ regular space is a T₃ space);
  • normalSpaceOfT3SecondCountable;
  • compact_t2_tot_disc_iff_tot_sep (the Iff.mp implication);
  • loc_compact_t2_tot_disc_iff_tot_sep;
  • UniformSpace.secondCountable_of_separable
@alexjbest
Copy link
Member

One thing to note here is that loops which have data in are still potentially dangerous I believe.

It doesn't look like this affects Yury's examples, but for example one might want the instance that a finite integral domain is a field, as this instance presumably will construct the inv field out of some nontrivial mathematics.
This can cause issues when we have an existing finite field which has a well defined inverse but we now have two ways of getting the inverse, the original one and the one constructed by the mathematical theorem that a finite integral domain is a field.
Maybe priorities are enough to fix this? I'm not sure

@alreadydone
Copy link
Contributor

alreadydone commented Sep 9, 2023

Related: #6646

There are still mysterious issues impairing performance even for Prop-valued classes. (See also Zulip)

@urkud
Copy link
Member Author

urkud commented Sep 10, 2023

@alexjbest Indeed, I'm talking about Prop-valued classes only.

bors bot pushed a commit that referenced this issue Sep 12, 2023
* Rename `NormalSpace` to `T4Space`.
* Add `NormalSpace`, a version without the `T1Space` assumption.
* Adjust some theorems.
* Supersedes thus closes #6892.
* Add some instance cycles, see #2030
bors bot pushed a commit that referenced this issue Sep 12, 2023
* Rename `NormalSpace` to `T4Space`.
* Add `NormalSpace`, a version without the `T1Space` assumption.
* Adjust some theorems.
* Supersedes thus closes #6892.
* Add some instance cycles, see #2030
bors bot pushed a commit that referenced this issue Sep 12, 2023
* Rename `NormalSpace` to `T4Space`.
* Add `NormalSpace`, a version without the `T1Space` assumption.
* Adjust some theorems.
* Supersedes thus closes #6892.
* Add some instance cycles, see #2030
bors bot pushed a commit that referenced this issue Sep 12, 2023
* Rename `NormalSpace` to `T4Space`.
* Add `NormalSpace`, a version without the `T1Space` assumption.
* Adjust some theorems.
* Supersedes thus closes #6892.
* Add some instance cycles, see #2030
bors bot pushed a commit that referenced this issue Sep 12, 2023
* Rename `NormalSpace` to `T4Space`.
* Add `NormalSpace`, a version without the `T1Space` assumption.
* Adjust some theorems.
* Supersedes thus closes #6892.
* Add some instance cycles, see #2030
kodyvajjha pushed a commit that referenced this issue Sep 22, 2023
* Rename `NormalSpace` to `T4Space`.
* Add `NormalSpace`, a version without the `T1Space` assumption.
* Adjust some theorems.
* Supersedes thus closes #6892.
* Add some instance cycles, see #2030
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants