Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - refactor: split NormalSpace into NormalSpace and T4Space #7072

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - refactor: split NormalSpace into NormalSpace and T4Space #7072

wants to merge 9 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Sep 10, 2023 •
edited

Open in Gitpod

@urkud urkud added awaiting-review The author would like community review of the PR t-topology Topological spaces, uniform spaces, metric spaces, filters labels Sep 10, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Sep 10, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Sep 10, 2023
jcommelin
jcommelin approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Sep 12, 2023
bors bot pushed a commit that referenced this pull request Sep 12, 2023
@urkud
refactor: split NormalSpace into NormalSpace and T4Space (#7072)
cc5af48 
* Rename `NormalSpace` to `T4Space`.
* Add `NormalSpace`, a version without the `T1Space` assumption.
* Adjust some theorems.
* Supersedes thus closes #6892.
* Add some instance cycles, see #2030
@bors
Copy link

bors bot commented Sep 12, 2023

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Sep 12, 2023
@urkud
refactor: split NormalSpace into NormalSpace and T4Space (#7072)
98e99da 
* Rename `NormalSpace` to `T4Space`.
* Add `NormalSpace`, a version without the `T1Space` assumption.
* Adjust some theorems.
* Supersedes thus closes #6892.
* Add some instance cycles, see #2030
@bors
Copy link

bors bot commented Sep 12, 2023

Build failed (retrying...):

@urkud
Copy link
Member Author

urkud commented Sep 12, 2023

bors merge

bors bot pushed a commit that referenced this pull request Sep 12, 2023
@urkud
refactor: split NormalSpace into NormalSpace and T4Space (#7072)
c24a080 
* Rename `NormalSpace` to `T4Space`.
* Add `NormalSpace`, a version without the `T1Space` assumption.
* Adjust some theorems.
* Supersedes thus closes #6892.
* Add some instance cycles, see #2030
@bors
Copy link

bors bot commented Sep 12, 2023

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Sep 12, 2023
@urkud
refactor: split NormalSpace into NormalSpace and T4Space (#7072)
1f297aa 
* Rename `NormalSpace` to `T4Space`.
* Add `NormalSpace`, a version without the `T1Space` assumption.
* Adjust some theorems.
* Supersedes thus closes #6892.
* Add some instance cycles, see #2030
@bors
Copy link

bors bot commented Sep 12, 2023

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Sep 12, 2023
@urkud
refactor: split NormalSpace into NormalSpace and T4Space (#7072)
bf815bd 
* Rename `NormalSpace` to `T4Space`.
* Add `NormalSpace`, a version without the `T1Space` assumption.
* Adjust some theorems.
* Supersedes thus closes #6892.
* Add some instance cycles, see #2030
@bors
Copy link

bors bot commented Sep 12, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title refactor: split NormalSpace into NormalSpace and T4Space [Merged by Bors] - refactor: split NormalSpace into NormalSpace and T4Space Sep 12, 2023
@bors bors bot closed this Sep 12, 2023
@bors bors bot deleted the YK-normal-T4 branch September 12, 2023 19:07
kodyvajjha pushed a commit that referenced this pull request Sep 22, 2023
@urkud @kodyvajjha
refactor: split NormalSpace into NormalSpace and T4Space (#7072)
7ab4b5d 
* Rename `NormalSpace` to `T4Space`.
* Add `NormalSpace`, a version without the `T1Space` assumption.
* Adjust some theorems.
* Supersedes thus closes #6892.
* Add some instance cycles, see #2030
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors. t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @jcommelin @leanprover-community-mathlib4-bot