[Merged by Bors] - feat(CategoryTheory/Monoidal): partially setting simp lemmas #10061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuma-mizuno
changed the title
yuma-mizuno
changed the title
10 tasks
yuma-mizuno
added
awaiting-review
Closed
1 task
joelriou
reviewed
Jan 30, 2024
Comment on lines
814
to
819
| theorem rightUnitor_conjugation {X Y : C} (f : X ⟶ Y) : | ||
| f ⊗ 𝟙 (𝟙_ C) = (ρ_ X).hom ≫ f ≫ (ρ_ Y).inv := by | ||
| simp | ||
| #align category_theory.monoidal_category.right_unitor_conjugation CategoryTheory.MonoidalCategory.rightUnitor_conjugation | ||
|
|
||
| theorem leftUnitor_conjugation {X Y : C} (f : X ⟶ Y) : |
There was a problem hiding this comment.
These two lemmas could have the reassoc attribute. Otherwise, the PR looks great to me!
joelriou
added
awaiting-author
yuma-mizuno
added
awaiting-review
|
Thanks! bors merge |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jan 31, 2024
Extracted from #6307. The main reason why #6307 is so large is that many tensoring of identity morphisms that appear in mathlib should be replaced with whiskerings. This PR will leave this issue and deal with other parts. That is, we do not set `id_tensorHom` and `tensorHom_id` as simple lemmas at this moment, We can set them as simp lemmas locally to enable simple normal forms.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #6307. The main reason why #6307 is so large is that many tensoring of identity morphisms that appear in mathlib should be replaced with whiskerings. This PR will leave this issue and deal with other parts. That is, we do not set
id_tensorHomandtensorHom_idas simple lemmas at this moment, We can set them as simp lemmas locally to enable simple normal forms.