Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: a polynomial over a perfect field is separable iff it is square-free #10170

Closed
wants to merge 5 commits into from

Conversation

ocfnash
Copy link
Contributor

@ocfnash ocfnash commented Feb 1, 2024

Yet another small step toward Jordan-Chevalley-Dunford.

This was far more work than expected, partly because of missing API for Squarefree, and partly because the definition IsCoprime is the wrong concept for unique factorization domains.


Open in Gitpod

@ocfnash ocfnash added WIP Work in progress t-algebra Algebra (groups, rings, fields etc) labels Feb 1, 2024
Mathlib.lean Show resolved Hide resolved
Mathlib.lean Show resolved Hide resolved
@ocfnash ocfnash added awaiting-review The author would like community review of the PR awaiting-CI and removed WIP Work in progress labels Feb 2, 2024
@jcommelin jcommelin changed the title feat: a polynomial of perfect field is separable iff it is square-free feat: a polynomial over a perfect field is separable iff it is square-free Feb 3, 2024
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The UFD proofs are on the longer side, but it sounds like there's an incoming refactor anyways, so I think we shouldn't spend too much energy on optimizing them.

bors d+

Mathlib/Algebra/Squarefree/UniqueFactorizationDomain.lean Outdated Show resolved Hide resolved
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 3, 2024

✌️ ocfnash can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated and removed awaiting-review The author would like community review of the PR labels Feb 3, 2024
@ocfnash ocfnash added the auto-merge-after-CI Please do not add manually. Requests for a bot to merge automatically once CI is done. label Feb 3, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

As this PR is labelled auto-merge-after-CI, we are now sending it to bors:

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Feb 3, 2024
…-free (#10170)

Yet another small step toward Jordan-Chevalley-Dunford.

This was far more work than expected, partly because of missing API for `Squarefree`, and partly because the definition `IsCoprime` is the wrong concept for unique factorization domains.
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 3, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: a polynomial over a perfect field is separable iff it is square-free [Merged by Bors] - feat: a polynomial over a perfect field is separable iff it is square-free Feb 3, 2024
@mathlib-bors mathlib-bors bot closed this Feb 3, 2024
@mathlib-bors mathlib-bors bot deleted the ocfnash/pf_sep_iff_sf branch February 3, 2024 12:31
mathlib-bors bot pushed a commit that referenced this pull request Feb 5, 2024
In fact this theorem admits a proof without using any lemmas introduced in #10170.

For this I had to remove some redundant [GCDMonoid R] assumptions in RingTheory/PrincipalIdealDomain.lean.



Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
Vierkantor pushed a commit that referenced this pull request Feb 5, 2024
In fact this theorem admits a proof without using any lemmas introduced in #10170.

For this I had to remove some redundant [GCDMonoid R] assumptions in RingTheory/PrincipalIdealDomain.lean.



Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
atarnoam pushed a commit that referenced this pull request Feb 9, 2024
…-free (#10170)

Yet another small step toward Jordan-Chevalley-Dunford.

This was far more work than expected, partly because of missing API for `Squarefree`, and partly because the definition `IsCoprime` is the wrong concept for unique factorization domains.
atarnoam pushed a commit that referenced this pull request Feb 9, 2024
In fact this theorem admits a proof without using any lemmas introduced in #10170.

For this I had to remove some redundant [GCDMonoid R] assumptions in RingTheory/PrincipalIdealDomain.lean.



Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-after-CI Please do not add manually. Requests for a bot to merge automatically once CI is done. delegated t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants