[Merged by Bors] - chore: golf separable_iff_squarefree
#10236
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alreadydone
added
awaiting-review
ocfnash
approved these changes
Feb 4, 2024
|
✌️ alreadydone can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-mathlib4-bot
added
delegated
and removed
awaiting-review
alreadydone
added
the
auto-merge-after-CI
|
As this PR is labelled bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 5, 2024
In fact this theorem admits a proof without using any lemmas introduced in #10170. For this I had to remove some redundant [GCDMonoid R] assumptions in RingTheory/PrincipalIdealDomain.lean. Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
separable_iff_squarefreeseparable_iff_squarefree
Vierkantor
pushed a commit
that referenced
this pull request
Feb 5, 2024
In fact this theorem admits a proof without using any lemmas introduced in #10170. For this I had to remove some redundant [GCDMonoid R] assumptions in RingTheory/PrincipalIdealDomain.lean. Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
atarnoam
pushed a commit
that referenced
this pull request
Feb 9, 2024
In fact this theorem admits a proof without using any lemmas introduced in #10170. For this I had to remove some redundant [GCDMonoid R] assumptions in RingTheory/PrincipalIdealDomain.lean. Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In fact this theorem admits a proof without using any lemmas introduced in #10170.
For this I had to remove some redundant [GCDMonoid R] assumptions in RingTheory/PrincipalIdealDomain.lean.
DecompositionMonoid will be a separate PR; independently I think most results about IsCoprime can be generalized to IsRelPrime (defined as
∀ p, p ∣ x → p ∣ y → IsUnit p), and maybe we should do that first ...