Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: Make the coercion ℝ≥0 → ℝ≥0∞ commute defeqly with nsmul and pow #10225

Closed
wants to merge 15 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented Feb 3, 2024

by tweaking the definition of the AddMonoid and MonoidWithZero instances for WithTop. Also unprotect ENNReal.coe_injective and rename ENNReal.coe_eq_coe → ENNReal.coe_inj.

From LeanAPAP


Open in Gitpod

and make it defeq by tweaking the definition of
 the `AddMonoid (WithTop α)` instance. Unprotect `ENNReal.coe_injective`.

From LeanAPAP
@YaelDillies YaelDillies added the awaiting-review The author would like community review of the PR label Feb 3, 2024
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Thanks! CI is unhappy, but this should probably be an easy fix.

Is there a similar fix to be made to npow?

@mathlib-bors
Copy link

mathlib-bors bot commented Feb 3, 2024

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated and removed awaiting-review The author would like community review of the PR labels Feb 3, 2024
@eric-wieser eric-wieser changed the title feat: ↑(n • p) : ℝ≥0∞) = n • p feat: (↑(n • p) : ℝ≥0∞) = n • p Feb 3, 2024
@YaelDillies YaelDillies changed the title feat: (↑(n • p) : ℝ≥0∞) = n • p feat: Make the coercion ℝ≥0 → ℝ≥0∞ commute defeqly with nsmul and pow Feb 4, 2024
@eric-wieser
Copy link
Member

Also reorder WithOne material. Algebra.Group.WithOne.Defs was hiding a Ring import! I credit Johan and Mario for leanprover-community/mathlib#2707.

This PR is getting quite big; can you do this separately?

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added blocked-by-other-PR This PR depends on another PR which is still in the queue. merge-conflict The PR has a merge conflict with master, and needs manual merging. labels Feb 5, 2024
@YaelDillies YaelDillies removed blocked-by-other-PR This PR depends on another PR which is still in the queue. merge-conflict The PR has a merge conflict with master, and needs manual merging. labels Feb 6, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

This PR/issue depends on:

@YaelDillies
Copy link
Collaborator Author

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Feb 6, 2024
… `pow` (#10225)

by tweaking the definition of the `AddMonoid` and `MonoidWithZero` instances for `WithTop`. Also unprotect `ENNReal.coe_injective` and rename `ENNReal.coe_eq_coe → ENNReal.coe_inj`.

From LeanAPAP
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 6, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: Make the coercion ℝ≥0 → ℝ≥0∞ commute defeqly with nsmul and pow [Merged by Bors] - feat: Make the coercion ℝ≥0 → ℝ≥0∞ commute defeqly with nsmul and pow Feb 6, 2024
@mathlib-bors mathlib-bors bot closed this Feb 6, 2024
@mathlib-bors mathlib-bors bot deleted the ennreal_coe_nsmul branch February 6, 2024 20:30
atarnoam pushed a commit that referenced this pull request Feb 9, 2024
… `pow` (#10225)

by tweaking the definition of the `AddMonoid` and `MonoidWithZero` instances for `WithTop`. Also unprotect `ENNReal.coe_injective` and rename `ENNReal.coe_eq_coe → ENNReal.coe_inj`.

From LeanAPAP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants