New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: Make the coercion ℝ≥0 → ℝ≥0∞
commute defeqly with nsmul
and pow
#10225
Conversation
and make it defeq by tweaking the definition of the `AddMonoid (WithTop α)` instance. Unprotect `ENNReal.coe_injective`. From LeanAPAP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors d+
Thanks! CI is unhappy, but this should probably be an easy fix.
Is there a similar fix to be made to npow
?
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
↑(n • p) : ℝ≥0∞) = n • p
(↑(n • p) : ℝ≥0∞) = n • p
(↑(n • p) : ℝ≥0∞) = n • p
ℝ≥0 → ℝ≥0∞
commute defeqly with nsmul
and pow
This PR is getting quite big; can you do this separately? |
This PR/issue depends on:
|
bors merge |
… `pow` (#10225) by tweaking the definition of the `AddMonoid` and `MonoidWithZero` instances for `WithTop`. Also unprotect `ENNReal.coe_injective` and rename `ENNReal.coe_eq_coe → ENNReal.coe_inj`. From LeanAPAP
Pull request successfully merged into master. Build succeeded: |
ℝ≥0 → ℝ≥0∞
commute defeqly with nsmul
and pow
ℝ≥0 → ℝ≥0∞
commute defeqly with nsmul
and pow
… `pow` (#10225) by tweaking the definition of the `AddMonoid` and `MonoidWithZero` instances for `WithTop`. Also unprotect `ENNReal.coe_injective` and rename `ENNReal.coe_eq_coe → ENNReal.coe_inj`. From LeanAPAP
by tweaking the definition of the
AddMonoid
andMonoidWithZero
instances forWithTop
. Also unprotectENNReal.coe_injective
and renameENNReal.coe_eq_coe → ENNReal.coe_inj
.From LeanAPAP
WithOne
doesn't import rings #10275