[Merged by Bors] - chore: Make sure WithOne doesn't import rings
#10275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reorder the `WithOne` material. `Algebra.Group.WithOne.Defs` was hiding a `Ring` import! I credit Johan and Mario for leanprover-community/mathlib#2707.
YaelDillies
added
awaiting-review
Closed
1 task
eric-wieser
reviewed
Feb 5, 2024
Comment on lines
125
to
+126
| "Deconstruct an `x : WithZero α` to the underlying value in `α`, given a proof that `x ≠ 0`."] | ||
| def unone {x : WithOne α} (hx : x ≠ 1) : α := | ||
| WithBot.unbot x hx | ||
| def unone : ∀ {x : WithOne α}, x ≠ 1 → α | (x : α), _ => x |
There was a problem hiding this comment.
What's the motivation for this change?
There was a problem hiding this comment.
You don't need to import WithBot anymore. It's weird that WithBot API was used in WithOne API.
sgouezel
reviewed
Feb 6, 2024
| end WithZero | ||
|
|
||
| -- Check that we haven't needed to import all the basic lemmas about groups, | ||
| -- by asserting a random sample don't exist here: | ||
| assert_not_exists inv_involutive | ||
| assert_not_exists div_right_inj | ||
| assert_not_exists pow_ite | ||
|
|
There was a problem hiding this comment.
This is on purpose: The comment above only applies to the three previous assert_not_exists, not to this one.
|
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-mathlib4-bot
added
delegated
and removed
awaiting-review
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 6, 2024
Reorder the `WithOne` material. * `Algebra.Group.WithOne.Defs` was hiding a `Ring` import! I credit Johan and Mario for leanprover-community/mathlib#2707. * `WithBot` is not needed to define `WithOne.unone`. It's simpler to redefine it by hand. In the future, we might want to have an `Option` version (but not sure how much that's worth, since it would basically be `Option.get` again).
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
WithOne doesn't import ringsWithOne doesn't import rings
atarnoam
pushed a commit
that referenced
this pull request
Feb 9, 2024
Reorder the `WithOne` material. * `Algebra.Group.WithOne.Defs` was hiding a `Ring` import! I credit Johan and Mario for leanprover-community/mathlib#2707. * `WithBot` is not needed to define `WithOne.unone`. It's simpler to redefine it by hand. In the future, we might want to have an `Option` version (but not sure how much that's worth, since it would basically be `Option.get` again).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorder the
WithOnematerial.Algebra.Group.WithOne.Defswas hiding aRingimport! I credit Johan and Mario for [Merged by Bors] - refactor(algebra): merge init_.algebra into algebra mathlib#2707.WithBotis not needed to defineWithOne.unone. It's simpler to redefine it by hand. In the future, we might want to have anOptionversion (but not sure how much that's worth, since it would basically beOption.getagain).