Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: port Data.Set.Function #1035

Closed
wants to merge 15 commits into from

Conversation

j-loreaux
Copy link
Collaborator

mathlib3 SHA: 198161d833f2c01498c39c266b0b3dbe2c7a8c07

porting notes:

  1. There are just a few declarations that need fixing still
  2. This was mostly fine, primarily tedious. One place I had to give an ugly workaround to avoid using lift since we don't have that yet.

@j-loreaux j-loreaux added awaiting-review mathlib-port This is a port of a theory file from mathlib. WIP Work in progress and removed awaiting-review labels Dec 14, 2022
@mcdoll mcdoll added awaiting-review and removed WIP Work in progress labels Dec 15, 2022
@kim-em
Copy link
Contributor

kim-em commented Dec 15, 2022

bors merge

bors bot pushed a commit that referenced this pull request Dec 15, 2022
mathlib3 SHA: 198161d833f2c01498c39c266b0b3dbe2c7a8c07

porting notes: 
1. There are just a few declarations that need fixing still
2. This was mostly fine, primarily tedious. One place I had to give an ugly workaround to avoid using `lift` since we don't have that yet.

Co-authored-by: thorimur <68410468+thorimur@users.noreply.github.com>
Co-authored-by: Moritz Doll <moritz.doll@googlemail.com>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: Scott Morrison <scott@tqft.net>
@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Dec 15, 2022
@bors
Copy link

bors bot commented Dec 15, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Data.Set.Function [Merged by Bors] - feat: port Data.Set.Function Dec 15, 2022
@bors bors bot closed this Dec 15, 2022
@bors bors bot deleted the j-loreaux/data.set.function branch December 15, 2022 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants