-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: port Data.Set.Function #1035
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-loreaux
added
awaiting-review
mathlib-port
This is a port of a theory file from mathlib.
WIP
Work in progress
and removed
awaiting-review
labels
Dec 14, 2022
…ommunity/mathlib4 into j-loreaux/data.set.function
kim-em
reviewed
Dec 15, 2022
…ommunity/mathlib4 into j-loreaux/data.set.function
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Dec 15, 2022
mathlib3 SHA: 198161d833f2c01498c39c266b0b3dbe2c7a8c07 porting notes: 1. There are just a few declarations that need fixing still 2. This was mostly fine, primarily tedious. One place I had to give an ugly workaround to avoid using `lift` since we don't have that yet. Co-authored-by: thorimur <68410468+thorimur@users.noreply.github.com> Co-authored-by: Moritz Doll <moritz.doll@googlemail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Scott Morrison <scott@tqft.net>
github-actions
bot
added
ready-to-merge
This PR has been sent to bors.
and removed
awaiting-review
labels
Dec 15, 2022
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
feat: port Data.Set.Function
[Merged by Bors] - feat: port Data.Set.Function
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
mathlib-port
This is a port of a theory file from mathlib.
ready-to-merge
This PR has been sent to bors.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mathlib3 SHA: 198161d833f2c01498c39c266b0b3dbe2c7a8c07
porting notes:
lift
since we don't have that yet.